Page MenuHomePhabricator
Differential D16547

Fix firefox float bug in Conphernce menu
ClosedPublic
Actions

Authored by chad on Sep 13 2016, 6:18 PM.
Tags
None
Referenced Files
F14936018: D16547.id39829.diff
Sat, Feb 15, 1:38 PM
Unknown Object (File)
Sun, Feb 9, 2:25 AM
Unknown Object (File)
Thu, Feb 6, 12:01 PM
Unknown Object (File)
Mon, Jan 27, 5:49 PM
Unknown Object (File)
Sun, Jan 26, 8:54 AM
Unknown Object (File)
Fri, Jan 24, 4:16 PM
Unknown Object (File)
Dec 24 2024, 2:55 AM
Unknown Object (File)
Dec 6 2024, 3:53 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP98a62c9e4998: Fix firefox float bug in Conphernce menu
Summary

These floats were wonky in FF, adding some hardening to make sure they clear.

Test Plan

Firefox, Chrome, IE.

pasted_file (247×359 px, 42 KB)

Diff Detail

Repository
rP Phabricator
Branch
firefox-conph (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13709
Build 17690: Run Core Tests
Build 17689: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39829.Sep 13 2016, 6:18 PM
chad retitled this revision from to Fix firefox float bug in Conphernce menu.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptSep 13 2016, 6:18 PM
chad edited the test plan for this revision. (Show Details)Sep 13 2016, 6:19 PM
epriestley accepted this revision.Sep 13 2016, 6:33 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 13 2016, 6:33 PM
Closed by commit rP98a62c9e4998: Fix firefox float bug in Conphernce menu (authored by chad, committed by chad). · Explain WhySep 13 2016, 6:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
conpherence/
view/
2 lines
webroot/
rsrc/
css/
application/
conpherence/
1 line

Diff 39829

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceThreadListView.php

Loading...
View Options

webroot/rsrc/css/application/conpherence/menu.css

Loading...
Phabricator · Built by Phacility