Paths

Table of Contentst

Differential D16526

Add edit notes to Phriction emails
ClosedPublic
Actions

Authored by chad on Sep 9 2016, 2:13 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T9294: Phriction document-created email notifications do not include Edit Notes

Commits

rPb056b7f174b5: Add edit notes to Phriction emails

Summary

Fixes T9294. Adds edit notes.

Test Plan

Edit a document, see notes in email.

Diff Detail

Repository

rP Phabricator

Branch

email-phriction-notes (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13652
Build 17599: Run Core Tests
Build 17598: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39769.Sep 9 2016, 2:13 AM

chad retitled this revision from to Add edit notes to Phriction emails.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T9294: Phriction document-created email notifications do not include Edit Notes.

Herald added a subscriber: Korvin. · View Herald TranscriptSep 9 2016, 2:13 AM

epriestley accepted this revision.Sep 9 2016, 2:15 AM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/phriction/editor/PhrictionTransactionEditor.php
433	Prefer `if(strlen($description))` so the common and informative description "0" works correctly.

This revision is now accepted and ready to land.Sep 9 2016, 2:15 AM

Closed by commit rPb056b7f174b5: Add edit notes to Phriction emails (authored by chad, committed by chad). · Explain WhySep 9 2016, 2:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

editor/

PhrictionTransactionEditor.php

7 lines

Diff 39769

View Options

src/applications/phriction/editor/PhrictionTransactionEditor.php

Add edit notes to Phriction emailsClosedPublicActions