Page MenuHomePhabricator
Differential D16515

Add a few more high contrast CSS rules
ClosedPublic
Actions

Authored by chad on Sep 7 2016, 6:01 PM.
Tags
None
Referenced Files
F15431015: D16515.diff
Mon, Mar 24, 10:07 AM
F15423231: D16515.id39744.diff
Sat, Mar 22, 2:08 PM
F15397750: D16515.id39745.diff
Sun, Mar 16, 10:07 PM
F15334647: D16515.id.diff
Mar 8 2025, 11:09 AM
F15299070: D16515.id39745.diff
Mar 5 2025, 2:14 PM
Unknown Object (File)
Feb 23 2025, 6:33 AM
Unknown Object (File)
Feb 18 2025, 11:43 AM
Unknown Object (File)
Feb 13 2025, 11:37 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPe2430d0aa534: Add a few more high contrast CSS rules
Summary

In new PHUITwoColumnLayout, some new colors were used that aren't in the High Contrast PostProcessor. Adding them and proper fallbacks.

Test Plan

High Contrast on/off on a timeline page.

Diff Detail

Repository
rP Phabricator
Branch
high-contrast (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13623
Build 17556: Run Core Tests
Build 17555: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39744.Sep 7 2016, 6:01 PM
chad retitled this revision from to Add a few more high contrast CSS rules.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptSep 7 2016, 6:01 PM
epriestley accepted this revision.Sep 7 2016, 6:02 PM
epriestley edited edge metadata.
epriestley added inline comments.
webroot/rsrc/css/phui/phui-two-column-view.css
158–159

(Remove rule completely?)

This revision is now accepted and ready to land.Sep 7 2016, 6:02 PM
Closed by commit rPe2430d0aa534: Add a few more high contrast CSS rules (authored by chad, committed by chad). · Explain WhySep 7 2016, 6:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
applications/
celerity/
postprocessor/
1 line
webroot/
rsrc/
css/
phui/
2 lines
1 line

Diff 39744

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/celerity/postprocessor/CelerityHighContrastPostprocessor.php

Loading...
View Options

webroot/rsrc/css/phui/phui-curtain-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-two-column-view.css

Loading...
Phabricator · Built by Phacility