Paths

Table of Contentst

Differential D16509

Make storage adjustment a little nicer, especially the first time
ClosedPublic
Actions

Authored by epriestley on Sep 7 2016, 2:54 PM.

Tags

None

Referenced Files

	F15512410: D16509.id.diff
	Thu, Apr 17, 10:28 AM

	F15510978: D16509.diff
	Wed, Apr 16, 10:46 PM

	F15462425: D16509.id.diff
	Tue, Apr 1, 3:04 PM

	F15442513: D16509.id39735.diff
	Wed, Mar 26, 11:45 PM

	F15442510: D16509.id39728.diff
	Wed, Mar 26, 11:45 PM

	F15442509: D16509.id.diff
	Wed, Mar 26, 11:45 PM

	F15441556: D16509.diff
	Wed, Mar 26, 6:47 PM

	F15388707: D16509.id.diff
	Mar 15 2025, 4:16 AM

Subscribers

None

Tokens

"Dat Boi" token, awarded by chad.

Details

Reviewers

Maniphest Tasks

T11583: When initializing a new database, just apply adjustments without prompting

Commits

rPb7e51877c316: Make storage adjustment a little nicer, especially the first time

Summary

Fixes T11583.

When users run bin/storage upgrade for the first time on a new install, we currently give them a prompt which feels rough and which they can only reasonably ever answer "yes" to.
We generally use cautionary language ("found issues with schema") in this workflow. Adjustments are now routine, so use more neutral and progress-oriented language ("found adjustments to apply").

Test Plan

Ran bin/storage upgrade --namesapce kappa123, got an adjustment using neutral language without prompting.
Dropped a key, ran bin/storage upgrade, got normal workflow (but with more neutral language).

Diff Detail

Repository

Branch

niceadjust

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13607
Build 17532: Run Core Tests
Build 17531: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39728.Sep 7 2016, 2:54 PM

epriestley retitled this revision from to Make storage adjustment a little nicer, especially the first time.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11583: When initializing a new database, just apply adjustments without prompting.

chad accepted this revision.Sep 7 2016, 4:05 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 7 2016, 4:05 PM

chad awarded a token.Sep 7 2016, 4:05 PM

Closed by commit rPb7e51877c316: Make storage adjustment a little nicer, especially the first time (authored by epriestley, committed by epriestley). · Explain WhySep 7 2016, 4:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

storage/

management/

workflow/

PhabricatorStorageManagementWorkflow.php

21 lines

Diff 39728

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

Loading...