Page MenuHomePhabricator
Differential D16506

Basic kbd CSS for remarkup
ClosedPublic
Actions

Authored by chad on Sep 7 2016, 4:24 AM.
Tags
None
Referenced Files
F14045450: D16506.diff
Wed, Nov 13, 4:36 AM
F14031916: D16506.id39729.diff
Sat, Nov 9, 12:15 PM
F14031915: D16506.id39722.diff
Sat, Nov 9, 12:14 PM
F14031914: D16506.id.diff
Sat, Nov 9, 12:14 PM
F14019719: D16506.diff
Tue, Nov 5, 11:31 PM
F14011571: D16506.id39722.diff
Fri, Nov 1, 3:09 AM
F14010794: D16506.id39722.diff
Thu, Oct 31, 12:19 PM
F14003060: D16506.id39722.diff
Sat, Oct 26, 1:43 AM
View All Files
Subscribers
Korvin
stratosgear
Tokens
"Cup of Joe" token, awarded by epriestley.

Details

Reviewers
stratosgear
epriestley
Commits
rP9ced2d7eb514: Basic kbd CSS for remarkup
Summary

Keyboard key CSS for Remarkup.

Test Plan

edit test in html, see new CSS

pasted_file (202×356 px, 14 KB)

Diff Detail

Repository
rP Phabricator
Branch
remarkup-kbd (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 13601
Build 17522: Run Core Tests
Build 17521: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39722.Sep 7 2016, 4:24 AM
chad retitled this revision from to Basic kbd CSS for remarkup.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptSep 7 2016, 4:24 AM
chad edited the test plan for this revision. (Show Details)Sep 7 2016, 4:24 AM
stratosgear accepted this revision.Sep 7 2016, 3:03 PM
stratosgear added a reviewer: stratosgear.
stratosgear added a subscriber: stratosgear.

LGTM :)

This revision is now accepted and ready to land.Sep 7 2016, 3:03 PM
epriestley accepted this revision.Sep 7 2016, 3:04 PM
epriestley edited edge metadata.

If @stratosgear says this is good, who am I to argue?

stratosgear added a comment.Sep 7 2016, 3:13 PM

I really admire, you guys, for your capacity to be so open and have such a great sense of humor about it all. Really!

Closed by commit rP9ced2d7eb514: Basic kbd CSS for remarkup (authored by chad, committed by chad). · Explain WhySep 7 2016, 3:21 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D16510: Add a {key ..} Remarkup rule for discussing keystrokes.Sep 7 2016, 3:53 PM
epriestley mentioned this in rP5f43abd7efb8: Add a {key ..} Remarkup rule for discussing keystrokes.Sep 7 2016, 4:09 PM
epriestley awarded a token.Sep 7 2016, 4:15 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
webroot/
rsrc/
css/
core/
16 lines

Diff 39722

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
Phabricator · Built by Phacility