Page MenuHomePhabricator

Add Slack authentication adapter
ClosedPublic

Authored by chad on Sep 6 2016, 5:25 AM.
Tags
None
Referenced Files
F15409933: D16495.id39704.diff
Wed, Mar 19, 6:01 AM
F15409649: D16495.id39704.diff
Wed, Mar 19, 4:49 AM
F15409212: D16495.id39704.diff
Wed, Mar 19, 3:37 AM
F15408967: D16495.id39704.diff
Wed, Mar 19, 2:25 AM
F15408770: D16495.id39704.diff
Wed, Mar 19, 1:12 AM
F15408581: D16495.id39704.diff
Tue, Mar 18, 11:59 PM
F15408399: D16495.id39704.diff
Tue, Mar 18, 10:47 PM
F15408187: D16495.id39704.diff
Tue, Mar 18, 9:36 PM
Subscribers

Details

Summary

This adds an authentication adapter to libphutil for Slack. Diff 1 of 2.

Test Plan

Create a new auth provider for Slack. Link Slack account to phacility.slack.com. Authenticate a new user, create an account with Slack reg provider.

Diff Detail

Repository
rPHU libphutil
Branch
slack-oauth
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13583
Build 17496: Run Core Tests
Build 17495: arc lint + arc unit

Event Timeline

chad retitled this revision from to Add Slack authentication adapter.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/future/slack/PhutilSlackFuture.php
51

This should probably be ltrim($this->action, '/') to strip leading slashes, or maybe just omit it entirely.

This revision is now accepted and ready to land.Sep 6 2016, 1:47 PM
chad edited edge metadata.
  • per comments
This revision was automatically updated to reflect the committed changes.