Page MenuHomePhabricator
Differential D16495

Add Slack authentication adapter
ClosedPublic
Actions

Authored by chad on Sep 6 2016, 5:25 AM.
Tags
None
Referenced Files
F15163499: D16495.diff
Tue, Feb 18, 11:41 AM
Unknown Object (File)
Tue, Feb 11, 11:03 PM
Unknown Object (File)
Sun, Feb 9, 3:27 PM
Unknown Object (File)
Sun, Feb 9, 2:18 AM
Unknown Object (File)
Sun, Feb 9, 2:18 AM
Unknown Object (File)
Sun, Feb 9, 2:18 AM
Unknown Object (File)
Sun, Feb 9, 2:18 AM
Unknown Object (File)
Sun, Feb 9, 1:23 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPHUb00eff539ee7: Add Slack authentication adapter
Summary

This adds an authentication adapter to libphutil for Slack. Diff 1 of 2.

Test Plan

Create a new auth provider for Slack. Link Slack account to phacility.slack.com. Authenticate a new user, create an account with Slack reg provider.

Diff Detail

Repository
rPHU libphutil
Branch
slack-oauth
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13576
Build 17484: Run Core Tests
Build 17483: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39699.Sep 6 2016, 5:25 AM
chad retitled this revision from to Add Slack authentication adapter.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptSep 6 2016, 5:25 AM
epriestley accepted this revision.Sep 6 2016, 1:47 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/future/slack/PhutilSlackFuture.php
50

This should probably be ltrim($this->action, '/') to strip leading slashes, or maybe just omit it entirely.

This revision is now accepted and ready to land.Sep 6 2016, 1:47 PM
chad updated this revision to Diff 39704.Sep 6 2016, 3:50 PM
chad edited edge metadata.
  • per comments
Closed by commit rPHUb00eff539ee7: Add Slack authentication adapter (authored by chad, committed by chad). · Explain WhySep 6 2016, 3:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
auth/
61 lines
future/
slack/
87 lines

Diff 39699

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/auth/PhutilSlackAuthAdapter.php

Loading...
View Options

src/future/slack/PhutilSlackFuture.php

Loading...
Phabricator · Built by Phacility