Page MenuHomePhabricator

Add Slack authentication adapter
ClosedPublic

Authored by chad on Sep 6 2016, 5:25 AM.
Tags
None
Referenced Files
F15163499: D16495.diff
Tue, Feb 18, 11:41 AM
Unknown Object (File)
Tue, Feb 11, 11:03 PM
Unknown Object (File)
Sun, Feb 9, 3:27 PM
Unknown Object (File)
Sun, Feb 9, 2:18 AM
Unknown Object (File)
Sun, Feb 9, 2:18 AM
Unknown Object (File)
Sun, Feb 9, 2:18 AM
Unknown Object (File)
Sun, Feb 9, 2:18 AM
Unknown Object (File)
Sun, Feb 9, 1:23 AM
Subscribers

Details

Summary

This adds an authentication adapter to libphutil for Slack. Diff 1 of 2.

Test Plan

Create a new auth provider for Slack. Link Slack account to phacility.slack.com. Authenticate a new user, create an account with Slack reg provider.

Diff Detail

Repository
rPHU libphutil
Branch
slack-oauth
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13576
Build 17484: Run Core Tests
Build 17483: arc lint + arc unit

Event Timeline

chad retitled this revision from to Add Slack authentication adapter.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/future/slack/PhutilSlackFuture.php
50

This should probably be ltrim($this->action, '/') to strip leading slashes, or maybe just omit it entirely.

This revision is now accepted and ready to land.Sep 6 2016, 1:47 PM
chad edited edge metadata.
  • per comments
This revision was automatically updated to reflect the committed changes.