Page MenuHomePhabricator
Differential D16479

Add a basic first feed story on /home/
ClosedPublic
Actions

Authored by chad on Aug 31 2016, 8:11 PM.
Tags
None
Referenced Files
F15388533: D16479.id39651.diff
Sat, Mar 15, 3:57 AM
F15383501: D16479.id39650.diff
Fri, Mar 14, 4:56 PM
F15324267: D16479.id39651.diff
Fri, Mar 7, 1:21 AM
Unknown Object (File)
Feb 18 2025, 11:40 AM
Unknown Object (File)
Feb 17 2025, 1:43 AM
Unknown Object (File)
Feb 3 2025, 7:55 PM
Unknown Object (File)
Jan 24 2025, 12:50 AM
Unknown Object (File)
Jan 22 2025, 12:56 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T11132: New Phabricator NUX
Commits
rP4dacf4d3ad4b: Add a basic first feed story on /home/
Summary

Ref T11132. Adds a text panel to feed if no stories are present and the user is an admin. Seems ok-ish for 15 minutes. Happy to take content suggestions.

Test Plan

Make a new install, see panel. Log in as new user, don't see panel.

Diff Detail

Repository
rP Phabricator
Branch
first-feed (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13526
Build 17407: Run Core Tests
Build 17406: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39649.Aug 31 2016, 8:11 PM
chad retitled this revision from to Add a basic first feed story on /home/.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T11132: New Phabricator NUX.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 31 2016, 8:11 PM
chad updated this revision to Diff 39650.Aug 31 2016, 8:17 PM
  • swap people for github
chad added a comment.Aug 31 2016, 8:20 PM

pasted_file (319×502 px, 30 KB)

epriestley edited edge metadata.Aug 31 2016, 8:29 PM

The invite link won't work in the Phacility cluster. We could show it conditionally, if cluster.instance is not defined.

Twitter link should probably be https://

In the "Quick Start Guide" (config/welcome/), the "Create a New Repository" link is wrong.

src/applications/home/controller/PhabricatorHomeMainController.php
206

Unused.

chad added a comment.Aug 31 2016, 8:31 PM

good catch!

chad added a comment.Aug 31 2016, 8:54 PM

Next diff will remove the old Welcome page, cleared up the link for now.

chad updated this revision to Diff 39651.Aug 31 2016, 8:54 PM
chad edited edge metadata.
  • fix diffusion link, test for Phacility instance
epriestley accepted this revision.Aug 31 2016, 8:56 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 31 2016, 8:56 PM
Closed by commit rP4dacf4d3ad4b: Add a basic first feed story on /home/ (authored by chad, committed by chad). · Explain WhyAug 31 2016, 8:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
config/
controller/
2 lines
home/
controller/
29 lines

Diff 39651

View Options

src/applications/config/controller/PhabricatorConfigWelcomeController.php

Loading...
View Options

src/applications/home/controller/PhabricatorHomeMainController.php

Loading...
Phabricator · Built by Phacility