Page MenuHomePhabricator
Differential D16475

Add some icons/color to Config Settings UI
ClosedPublic
Actions

Authored by chad on Aug 30 2016, 7:54 PM.
Tags
None
Referenced Files
F14012494: D16475.id39641.diff
Fri, Nov 1, 1:37 PM
F14012300: D16475.diff
Fri, Nov 1, 10:45 AM
F13988987: D16475.diff
Mon, Oct 21, 5:20 PM
F13987493: D16475.id.diff
Mon, Oct 21, 9:45 AM
Unknown Object (File)
Oct 8 2024, 5:39 AM
Unknown Object (File)
Sep 28 2024, 5:30 PM
Unknown Object (File)
Sep 10 2024, 3:20 PM
Unknown Object (File)
Aug 26 2024, 3:19 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPeac8171a63df: Add some icons/color to Config Settings UI
Summary

This adds status icons, locked, hidden, editable, customized, to the list of options in config. Makes it easier to read and assertain state.

Test Plan

View a hidden, customized, editable, and locked.

pasted_file (1×875 px, 224 KB)

Diff Detail

Repository
rP Phabricator
Branch
config-3 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13515
Build 17389: Run Core Tests
Build 17388: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39640.Aug 30 2016, 7:54 PM
chad retitled this revision from to Add some icons/color to Config Settings UI.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 30 2016, 7:54 PM
chad edited the test plan for this revision. (Show Details)Aug 30 2016, 7:54 PM
epriestley accepted this revision.Aug 30 2016, 7:57 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 30 2016, 7:57 PM
Closed by commit rPeac8171a63df: Add some icons/color to Config Settings UI (authored by chad, committed by chad). · Explain WhyAug 30 2016, 7:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
config/
controller/
31 lines
view/
phui/
3 lines
webroot/
rsrc/
css/
phui/
13 lines

Diff 39640

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigGroupController.php

Loading...
View Options

src/view/phui/PHUIObjectItemView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
Phabricator · Built by Phacility