Page MenuHomePhabricator
Differential D16469

Fix search results with tables, fatals in Phortune
ClosedPublic
Actions

Authored by chad on Aug 30 2016, 2:19 AM.
Tags
None
Referenced Files
F15463507: D16469.id39623.diff
Wed, Apr 2, 12:21 AM
F15461422: D16469.id39622.diff
Tue, Apr 1, 8:12 AM
F15434728: D16469.id.diff
Tue, Mar 25, 5:02 AM
F15431805: D16469.diff
Mon, Mar 24, 2:36 PM
F15414755: D16469.diff
Thu, Mar 20, 2:24 AM
F15399815: D16469.id39623.diff
Mar 17 2025, 7:52 AM
F15392354: D16469.id.diff
Mar 15 2025, 2:44 PM
F15387763: D16469.id39622.diff
Mar 15 2025, 2:52 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP3f7021e0d88b: (stable) Fix search results with tables, fatals in Phortune
rPb75cea55a782: Fix search results with tables, fatals in Phortune
Summary

Previously we collapsed all table search results, but the new UI doesn't need it. Remove unused methods and fix CSS.

Test Plan

Legalpad Signatures, Phortune Accounts.

Diff Detail

Repository
rP Phabricator
Branch
phortune (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13498
Build 17363: Run Core Tests
Build 17362: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39622.Aug 30 2016, 2:19 AM
chad retitled this revision from to Fix search results with tables.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 30 2016, 2:19 AM
chad retitled this revision from Fix search results with tables to Fix search results with tables, fatals in Phortune.Aug 30 2016, 3:10 AM
chad edited the test plan for this revision. (Show Details)
chad updated this revision to Diff 39623.Aug 30 2016, 3:10 AM
chad retitled this revision from Fix search results with tables, fatals in Phortune to Fix search results with tables.
chad edited the test plan for this revision. (Show Details)
  • found a few more fatals
chad added a comment.Aug 30 2016, 3:11 AM

@epriestley this will need cherry picked and rolled to Phacility. :(

See: https://admin.phacility.com/phortune/account/

chad retitled this revision from Fix search results with tables to Fix search results with tables, fatals in Phortune.Aug 30 2016, 3:19 AM
epriestley accepted this revision.Aug 30 2016, 3:38 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 30 2016, 3:38 AM
Closed by commit rPb75cea55a782: Fix search results with tables, fatals in Phortune (authored by chad, committed by chad). · Explain WhyAug 30 2016, 3:39 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T11558: Update-after-commit possibly got mangled in diff-to-file change?.Aug 30 2016, 2:21 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
phortune/
controller/
4 lines
2 lines
query/
2 lines
search/
controller/
3 lines
view/
10 lines
webroot/
rsrc/
css/
application/
search/
5 lines

Diff 39623

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/phortune/controller/PhortuneAccountListController.php

Loading...
View Options

src/applications/phortune/controller/PhortuneProductListController.php

Loading...
View Options

src/applications/phortune/query/PhortuneMerchantSearchEngine.php

Loading...
View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
View Options

src/applications/search/view/PhabricatorApplicationSearchResultView.php

Loading...
View Options

webroot/rsrc/css/application/search/application-search-view.css

Loading...
Phabricator · Built by Phacility