Page MenuHomePhabricator
Differential D16467

Move Guides ObjectList styles to PHUIObjectItemListView
ClosedPublic
Actions

Authored by chad on Aug 29 2016, 3:54 PM.
Tags
None
Referenced Files
F15285625: D16467.diff
Tue, Mar 4, 2:51 PM
Unknown Object (File)
Mon, Feb 24, 7:11 AM
Unknown Object (File)
Tue, Feb 18, 11:39 AM
Unknown Object (File)
Jan 27 2025, 3:46 AM
Unknown Object (File)
Jan 26 2025, 10:20 PM
Unknown Object (File)
Jan 21 2025, 9:48 AM
Unknown Object (File)
Jan 17 2025, 9:51 PM
Unknown Object (File)
Dec 26 2024, 2:19 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP86231a9d6db5: Move Guides ObjectList styles to PHUIObjectItemListView
Summary

I plan to reuse these styles with Config, maybe also Almanac, etc.

Test Plan

Review /guides/, see same styles.

Diff Detail

Repository
rP Phabricator
Branch
guide-css (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13486
Build 17344: Run Core Tests
Build 17343: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39611.Aug 29 2016, 3:54 PM
chad retitled this revision from to Move Guides ObjectList styles to PHUIObjectItemListView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 29 2016, 3:54 PM
epriestley accepted this revision.Aug 29 2016, 4:23 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 29 2016, 4:23 PM
Closed by commit rP86231a9d6db5: Move Guides ObjectList styles to PHUIObjectItemListView (authored by chad, committed by chad). · Explain WhyAug 29 2016, 4:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
8 lines
src/
applications/
guides/
controller/
1 line
1 line
1 line
view/
4 lines
view/
phui/
9 lines
webroot/
rsrc/
css/
application/
guides/
phui/
33 lines

Diff 39611

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/guides/controller/PhabricatorGuideInstallController.php

Loading...
View Options

src/applications/guides/controller/PhabricatorGuideQuickStartController.php

Loading...
View Options

src/applications/guides/controller/PhabricatorGuideWelcomeController.php

Loading...
View Options

src/applications/guides/view/PhabricatorGuideListView.php

Loading...
View Options

src/view/phui/PHUIObjectItemListView.php

Loading...
View Options

webroot/rsrc/css/application/guides/guides.css

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
Phabricator · Built by Phacility