Page MenuHomePhabricator

Return Diffusion diffs through Files, not directly over Conduit
ClosedPublic

Authored by epriestley on Aug 26 2016, 5:28 PM.
Tags
None
Referenced Files
F14054609: D16460.diff
Sat, Nov 16, 3:20 AM
F14053585: D16460.id39599.diff
Fri, Nov 15, 5:20 PM
F14052891: D16460.diff
Fri, Nov 15, 11:23 AM
F14042241: D16460.diff
Tue, Nov 12, 1:39 AM
F14039804: D16460.id39590.diff
Mon, Nov 11, 6:22 AM
F14025844: D16460.diff
Thu, Nov 7, 8:50 PM
F14016271: D16460.id39590.diff
Mon, Nov 4, 7:37 AM
F13976790: D16460.id39599.diff
Oct 18 2024, 3:43 PM
Subscribers

Details

Summary

Fixes T10423. Ref T11524. This changes diffusion.rawdiffquery to return a file PHID instead of a blob of data.

This is better in general, but particularly better for huge diffs (as in T10423) and diffs with non-utf8 data (as in T10423).

Test Plan
  • Used bin/differential extract to extract a latin1 diff, got a clean diff.
  • Used bin/repository reparse --herald to rerun herald on a latin1 diff, got a clean result.
  • Pushed latin1 diffs to test commit hooks.
  • Triggered the the too large / too slow logic.
  • Viewed latin1 diffs in Diffusion.
  • Used "blame past this change" in Diffusion to hit the before logic.

Diff Detail

Repository
rP Phabricator
Branch
filediff3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13466
Build 17312: Run Core Tests
Build 17311: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Return Diffusion diffs through Files, not directly over Conduit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 26 2016, 5:41 PM
This revision was automatically updated to reflect the committed changes.