Page MenuHomePhabricator
Differential D16453

Add setup checks for unused homepage options
ClosedPublic
Actions

Authored by chad on Aug 25 2016, 7:01 PM.
Tags
None
Referenced Files
F14754962: D16453.id39577.diff
Tue, Jan 21, 3:42 PM
F14753732: D16453.id39576.diff
Tue, Jan 21, 3:18 PM
F14752613: D16453.id.diff
Tue, Jan 21, 1:00 PM
F14748576: D16453.diff
Tue, Jan 21, 10:59 AM
Unknown Object (File)
Dec 13 2024, 6:02 PM
Unknown Object (File)
Dec 7 2024, 1:10 PM
Unknown Object (File)
Dec 5 2024, 2:21 AM
Unknown Object (File)
Dec 4 2024, 2:30 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T5315: Remove the "welcome.html" configuration option when Dashboards is available
T11533: Upgrading: Changes to Default Homepage
Commits
rP9d9a47e9cf49: Add setup checks for unused homepage options
Summary

Ref T11533, Fixes T5315. Remove and add extra setup checks for removed homepage options.

Test Plan

Review text.

Diff Detail

Repository
rP Phabricator
Branch
config-check (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13452
Build 17290: Run Core Tests
Build 17289: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39576.Aug 25 2016, 7:01 PM
chad retitled this revision from to Add setup checks for unused homepage options.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T11533: Upgrading: Changes to Default Homepage.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 25 2016, 7:01 PM
epriestley edited edge metadata.Aug 25 2016, 7:04 PM

Remove welcome.html from PhabricatorCoreConfigOptions too? Did you already get that?

chad updated this revision to Diff 39577.Aug 25 2016, 7:07 PM
chad edited edge metadata.
  • remove welcome.html option
chad updated this object.Aug 25 2016, 7:07 PM
chad added a task: T5315: Remove the "welcome.html" configuration option when Dashboards is available.
epriestley accepted this revision.Aug 25 2016, 7:07 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 25 2016, 7:07 PM
Closed by commit rP9d9a47e9cf49: Add setup checks for unused homepage options (authored by chad, committed by chad). · Explain WhyAug 25 2016, 7:08 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D9672: Remove `welcome.html` config option.Aug 31 2016, 2:47 PM

Revision Contents
Changeset List

PathSize
src/
applications/
config/
check/
16 lines
maniphest/
config/
22 lines

Diff 39576

View Options

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php

Loading...
View Options

src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php

Loading...
Phabricator · Built by Phacility