Page MenuHomePhabricator

Update Preamble documentation for clusters with mixed request sources and loadbalancer chains
ClosedPublic

Authored by epriestley on Aug 16 2016, 10:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 10, 1:42 AM
Unknown Object (File)
Sun, Dec 8, 3:42 PM
Unknown Object (File)
Sat, Dec 7, 6:59 AM
Unknown Object (File)
Nov 19 2024, 11:25 AM
Unknown Object (File)
Nov 9 2024, 12:08 PM
Unknown Object (File)
Nov 4 2024, 2:20 PM
Unknown Object (File)
Oct 24 2024, 12:55 PM
Unknown Object (File)
Oct 21 2024, 1:48 AM
Subscribers
None

Details

Summary

Fixes T11487. Improve documentation for three situations:

  • When you configure a cluster behind a load balancer, all requests are trusted but not all have an "X-Forwarded-For" header. Change the suggested snippet to read this header only if it exists.
  • When a request goes through a series of load balancers (as with a CDN) they can end up writing a list of IPs to the header. Parse these.
  • Remove the "rate limiting" stuff -- this got disabled/removed a long time ago and is misleading/incorrect.
Test Plan

Read documentation.

Diff Detail

Repository
rP Phabricator
Branch
doc1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 13324
Build 17089: Run Core Tests
Build 17088: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39446.
epriestley retitled this revision from to Update Preamble documentation for clusters with mixed request sources and loadbalancer chains.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Add the other half of a missing sentence
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 16 2016, 11:05 PM
This revision was automatically updated to reflect the committed changes.