Page MenuHomePhabricator

Fix misleading error message when only cluster database masters are configured
ClosedPublic

Authored by epriestley on Aug 10 2016, 7:04 PM.
Tags
None
Referenced Files
F13234947: D16386.id39410.diff
Tue, May 21, 4:00 AM
F13216877: D16386.id39410.diff
Sat, May 18, 2:48 AM
F13214589: D16386.diff
Fri, May 17, 11:38 AM
F13210931: D16386.diff
Fri, May 17, 5:20 AM
F13196294: D16386.diff
Sun, May 12, 11:09 PM
Unknown Object (File)
Mon, May 6, 6:05 PM
Unknown Object (File)
Fri, May 3, 3:43 AM
Unknown Object (File)
Mon, Apr 29, 3:45 PM
Subscribers
None

Details

Summary

Fixes T11446. We can raise the misleading error:

No valid databases are configured!

...when a valid master is configured but unreachable.

Instead, more carefully raise either "nothing is configured" or "nothing is reachable".

Test Plan

Configured only a master, artificially severed it, got "nothing is reachable" instead of "nothing is configured".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix misleading error message when only cluster database masters are configured.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 10 2016, 7:54 PM
This revision was automatically updated to reflect the committed changes.