Page MenuHomePhabricator

Fix misleading error message when only cluster database masters are configured
ClosedPublic

Authored by epriestley on Aug 10 2016, 7:04 PM.
Tags
None
Referenced Files
F13330014: D16386.diff
Mon, Jun 17, 2:27 AM
F13318957: D16386.diff
Thu, Jun 13, 11:53 AM
F13292069: D16386.id39409.diff
Wed, Jun 5, 1:16 AM
F13290756: D16386.id39409.diff
Tue, Jun 4, 8:03 PM
F13275307: D16386.id39409.diff
Fri, May 31, 4:38 AM
F13271211: D16386.id.diff
Wed, May 29, 6:05 PM
F13261710: D16386.diff
Mon, May 27, 1:21 AM
F13234947: D16386.id39410.diff
Tue, May 21, 4:00 AM
Subscribers
None

Details

Summary

Fixes T11446. We can raise the misleading error:

No valid databases are configured!

...when a valid master is configured but unreachable.

Instead, more carefully raise either "nothing is configured" or "nothing is reachable".

Test Plan

Configured only a master, artificially severed it, got "nothing is reachable" instead of "nothing is configured".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix misleading error message when only cluster database masters are configured.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 10 2016, 7:54 PM
This revision was automatically updated to reflect the committed changes.