Page MenuHomePhabricator

Fix misleading error message when only cluster database masters are configured
ClosedPublic

Authored by epriestley on Aug 10 2016, 7:04 PM.
Tags
None
Referenced Files
F14347924: D16386.diff
Thu, Dec 19, 4:02 AM
Unknown Object (File)
Tue, Dec 17, 8:29 AM
Unknown Object (File)
Thu, Dec 12, 8:31 PM
Unknown Object (File)
Wed, Dec 4, 8:10 PM
Unknown Object (File)
Wed, Nov 27, 11:13 PM
Unknown Object (File)
Sun, Nov 24, 12:56 PM
Unknown Object (File)
Sun, Nov 24, 6:28 AM
Unknown Object (File)
Nov 5 2024, 2:15 AM
Subscribers
None

Details

Summary

Fixes T11446. We can raise the misleading error:

No valid databases are configured!

...when a valid master is configured but unreachable.

Instead, more carefully raise either "nothing is configured" or "nothing is reachable".

Test Plan

Configured only a master, artificially severed it, got "nothing is reachable" instead of "nothing is configured".

Diff Detail

Repository
rP Phabricator
Branch
error1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13286
Build 17034: Run Core Tests
Build 17033: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix misleading error message when only cluster database masters are configured.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 10 2016, 7:54 PM
This revision was automatically updated to reflect the committed changes.