Differential D16363

Fix broken link to PHPExcel site
ClosedPublic
Actions

Authored by fooishbar on Aug 3 2016, 1:10 PM.

Tags

None

Referenced Files

	F17809536: D16363.diff
	Fri, Jul 25, 4:54 PM

	F17630865: D16363.diff
	Thu, Jul 10, 12:03 PM

	F17629518: D16363.diff
	Thu, Jul 10, 9:02 AM

	Unknown Object (File)
	Jun 27 2025, 7:44 AM

	Unknown Object (File)
	Jun 19 2025, 11:57 PM

	Unknown Object (File)
	Jun 18 2025, 9:40 PM

	Unknown Object (File)
	Jun 17 2025, 9:22 AM

	Unknown Object (File)
	May 27 2025, 11:23 AM

Subscribers

Tokens

"100" token, awarded by chad.

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rP518479a916a8: Fix broken link to PHPExcel site
rPeecf6b8ecabe: Fix broken link to PHPExcel site

Summary

phpexcel.net currently serves a 500 page, and the top Google hit for
PHPExcel (on codeplex) gives you a site warning you that it is 3 years
out of date, and to see GitHub instead.

Update the link from Maniphest's 'please install PHPExcel to enable
export' prompt.

Test Plan

Click 'Export to Excel' from Maniphest query result page without PHPExcel installed
Follow suggested link to install it
See code rather than a HTTP 500 error

Diff Detail

Repository

Branch

upstream (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13234
Build 16959: arc lint + arc unit

Event Timeline

fooishbar updated this revision to Diff 39356.Aug 3 2016, 1:10 PM

fooishbar retitled this revision from to Fix broken link to PHPExcel site.

fooishbar updated this object.

fooishbar edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 3 2016, 1:10 PM

Herald added a subscriber: epriestley. · View Herald Transcript

epriestley accepted this revision.Aug 3 2016, 2:45 PM

epriestley added a reviewer: epriestley.

This revision is now accepted and ready to land.Aug 3 2016, 2:45 PM

I added you to Blessed Committers, so you should be able to land this yourself (that project page has some details).

I also added you to Community, granting you sweeping janitorial powers on this install.

Closed by commit rP518479a916a8: Fix broken link to PHPExcel site (authored by fooishbar, committed by fooishbar). · Explain WhyAug 3 2016, 2:52 PM

Closed by commit rPeecf6b8ecabe: Fix broken link to PHPExcel site (authored by fooishbar, committed by fooishbar). · Explain Why

This revision was automatically updated to reflect the committed changes.

This revision was automatically updated to reflect the committed changes.

chad awarded a token.Aug 3 2016, 3:00 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

controller/

ManiphestExportController.php

4 lines

Diff 39356

src/applications/maniphest/controller/ManiphestExportController.php

Loading...