Page MenuHomePhabricator
Differential D16336

Give Calendar days from adjacent months a background color hint
ClosedPublic
Actions

Authored by epriestley on Jul 27 2016, 2:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 3:43 AM
Unknown Object (File)
Tue, Dec 17, 1:03 AM
Unknown Object (File)
Fri, Dec 13, 8:15 PM
Unknown Object (File)
Wed, Dec 4, 11:18 AM
Unknown Object (File)
Wed, Dec 4, 11:18 AM
Unknown Object (File)
Wed, Dec 4, 11:18 AM
Unknown Object (File)
Wed, Dec 4, 11:00 AM
Unknown Object (File)
Wed, Nov 27, 4:29 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11326: Improve Calendar v1 Design/UI/UX
Commits
rP89f6764e1bdb: Give Calendar days from adjacent months a background color hint
Summary

Ref T11326. When viewing "February", add a class to dates in January and March to let them be styled a little differently as a UI hint.

For now, I've given them a grey background. (Calendar.app changes the date number color instead.)

Test Plan

Screen Shot 2016-07-27 at 7.22.51 AM.png (1×1 px, 257 KB)

Diff Detail

Repository
rP Phabricator
Branch
cal4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13150
Build 16830: Run Core Tests
Build 16829: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39274.Jul 27 2016, 2:25 PM
epriestley retitled this revision from to Give Calendar days from adjacent months a background color hint.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11326: Improve Calendar v1 Design/UI/UX.
Herald edited edge metadata. · View Herald TranscriptJul 27 2016, 2:25 PM
chad accepted this revision.Jul 27 2016, 4:03 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 27 2016, 4:03 PM
Closed by commit rP89f6764e1bdb: Give Calendar days from adjacent months a background color hint (authored by epriestley, committed by epriestley). · Explain WhyJul 27 2016, 4:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
view/
phui/
calendar/
12 lines
webroot/
rsrc/
css/
phui/
calendar/
4 lines

Diff 39274

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarMonthView.php

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar-month.css

Loading...
Phabricator · Built by Phacility