Page MenuHomePhabricator
Differential D16308

Make Calendar day view a little more consistent
ClosedPublic
Actions

Authored by epriestley on Jul 15 2016, 9:04 PM.
Tags
None
Referenced Files
F15468096: D16308.id39219.diff
Thu, Apr 3, 8:13 PM
F15466413: D16308.diff
Thu, Apr 3, 5:10 AM
F15432387: D16308.diff
Mon, Mar 24, 5:54 PM
F15411478: D16308.id39219.diff
Wed, Mar 19, 9:19 AM
F15299451: D16308.id39222.diff
Mar 5 2025, 3:06 PM
Unknown Object (File)
Feb 27 2025, 6:53 AM
Unknown Object (File)
Feb 24 2025, 10:54 AM
Unknown Object (File)
Feb 21 2025, 12:40 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11326: Improve Calendar v1 Design/UI/UX
Commits
rP4859a3373921: Make Calendar day view a little more consistent
Summary

Ref T11326. This just cleans things up a little and removes some of the obvious layout/CSS issues.

Test Plan
  • Viewed day view before/after. Also viewed profile panel.

Before:

Screen Shot 2016-07-15 at 1.35.01 PM.png (1×1 px, 178 KB)

After:

Screen Shot 2016-07-15 at 2.01.19 PM.png (1×1 px, 190 KB)

Diff Detail

Repository
rP Phabricator
Branch
calx11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13098
Build 16746: Run Core Tests
Build 16745: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39219.Jul 15 2016, 9:04 PM
epriestley retitled this revision from to Make Calendar day view a little more consistent.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11326: Improve Calendar v1 Design/UI/UX.
Herald edited edge metadata. · View Herald TranscriptJul 15 2016, 9:04 PM
chad accepted this revision.Jul 15 2016, 9:19 PM
chad edited edge metadata.

I'm busy that day.

This revision is now accepted and ready to land.Jul 15 2016, 9:19 PM
Closed by commit rP4859a3373921: Make Calendar day view a little more consistent (authored by epriestley, committed by epriestley). · Explain WhyJul 15 2016, 9:24 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Jul 15 2016, 10:08 PM

:(

chad added a comment.Jul 15 2016, 10:09 PM

my hamster has a dentist appointment

Revision Contents
Changeset List

PathSize
resources/
celerity/
15 lines
src/
applications/
calendar/
query/
50 lines
people/
controller/
6 lines
view/
phui/
calendar/
16 lines
webroot/
rsrc/
css/
phui/
calendar/
37 lines
2 lines
js/
application/
calendar/
50 lines

Diff 39219

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarDayView.php

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar-day.css

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar-list.css

Loading...
View Options

webroot/rsrc/js/application/calendar/behavior-day-view.js

Loading...
Phabricator · Built by Phacility