Page MenuHomePhabricator
Differential D16306

Make Calendar month view events render a little more consistently
ClosedPublic
Actions

Authored by epriestley on Jul 15 2016, 7:10 PM.
Tags
None
Referenced Files
F15488402: D16306.diff
Thu, Apr 10, 9:55 PM
F15484851: D16306.diff
Wed, Apr 9, 8:33 PM
F15455187: D16306.id39217.diff
Sat, Mar 29, 10:42 PM
F15452806: D16306.id.diff
Sat, Mar 29, 7:25 AM
F15449035: D16306.id39217.diff
Fri, Mar 28, 8:17 AM
F15449034: D16306.id.diff
Fri, Mar 28, 8:17 AM
F15445915: D16306.id39215.diff
Thu, Mar 27, 4:31 PM
F15443475: D16306.id.diff
Thu, Mar 27, 4:37 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11326: Improve Calendar v1 Design/UI/UX
Commits
rPb6c3d184d200: Make Calendar month view events render a little more consistently
Summary

Ref T11326. This just inches things forward a little bit:

  • Make it easier to see current day.
  • Line-through cancelled events.
  • Don't colorize the whole event title, just use an Attending/Invited/Custom icon.
  • Slightly subtler treatment for all-day events.
Test Plan

See screenshot in T11326.

Diff Detail

Repository
rP Phabricator
Branch
calx10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13094
Build 16741: Run Core Tests
Build 16740: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39215.Jul 15 2016, 7:10 PM
epriestley retitled this revision from to Make Calendar month view events render a little more consistently.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11326: Improve Calendar v1 Design/UI/UX.
Herald edited edge metadata. · View Herald TranscriptJul 15 2016, 7:10 PM
chad accepted this revision.Jul 15 2016, 7:36 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 15 2016, 7:36 PM
Closed by commit rPb6c3d184d200: Make Calendar month view events render a little more consistently (authored by epriestley, committed by epriestley). · Explain WhyJul 15 2016, 8:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
8 lines
src/
applications/
calendar/
query/
78 lines
storage/
60 lines
view/
20 lines
view/
phui/
calendar/
24 lines
28 lines
webroot/
rsrc/
css/
phui/
calendar/
17 lines
10 lines

Diff 39215

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
View Options

src/applications/calendar/view/AphrontCalendarEventView.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarListView.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarMonthView.php

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar-month.css

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar.css

Loading...
Phabricator · Built by Phacility