Differential D16296

Make ghost event instances render better on the event list
ClosedPublic
Actions

Authored by epriestley on Jul 14 2016, 11:47 AM.

Details

Reviewers

chad

Maniphest Tasks

T11326: Improve Calendar v1 Design/UI/UX

Commits

rP7c9a74ce04d8: Make ghost event instances render better on the event list

Summary

Ref T11326. Currently, we render "E (99)" for ghost instances, which is meaningless and inconsistent.

Render these more sensibly and consistently.

Test Plan

Viewed event list, saw reasonable monograms / object names.

Diff Detail

Repository

rP Phabricator

Branch

calx1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13073
Build 16710: Run Core Tests
Build 16709: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39193.Jul 14 2016, 11:47 AM

epriestley retitled this revision from to Make ghost event instances render better on the event list.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11326: Improve Calendar v1 Design/UI/UX.

chad accepted this revision.Jul 14 2016, 1:55 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jul 14 2016, 1:55 PM

Closed by commit rP7c9a74ce04d8: Make ghost event instances render better on the event list (authored by epriestley, committed by epriestley). · Explain WhyJul 14 2016, 2:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

query/

PhabricatorCalendarEventSearchEngine.php

13 lines

Diff 39193

View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Make ghost event instances render better on the event listClosedPublicActions