Page MenuHomePhabricator
Differential D16290

Respect 12 hour vs 24 hour time formats in Calendar day views
ClosedPublic
Actions

Authored by epriestley on Jul 13 2016, 5:27 PM.
Tags
None
Referenced Files
F14492508: D16290.diff
Thu, Jan 2, 8:01 PM
Unknown Object (File)
Fri, Dec 20, 10:04 PM
Unknown Object (File)
Sat, Dec 14, 2:47 PM
Unknown Object (File)
Fri, Dec 13, 8:00 PM
Unknown Object (File)
Sun, Dec 8, 2:45 PM
Unknown Object (File)
Thu, Dec 5, 11:49 AM
Unknown Object (File)
Nov 25 2024, 2:46 PM
Unknown Object (File)
Nov 21 2024, 1:51 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9202: Calendar UI doesn't honor user time format preferences in day view
T10932: Daily view of calendar uses 12h (am/pm) marking of time, although preferences set to 24h
Commits
rP8062423271c7: Respect 12 hour vs 24 hour time formats in Calendar day views
Summary

Fixes T9202.

Test Plan
  • Viewed day in 12-hour, saw "8:00 PM".
  • Viewed day in 24-hour, saw "16:00".

Diff Detail

Repository
rP Phabricator
Branch
cal4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13060
Build 16691: Run Core Tests
Build 16690: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39180.Jul 13 2016, 5:27 PM
epriestley retitled this revision from to Respect 12 hour vs 24 hour time formats in Calendar day views.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10932: Daily view of calendar uses 12h (am/pm) marking of time, although preferences set to 24h.
epriestley updated this object.Jul 13 2016, 5:28 PM
epriestley added a task: T9202: Calendar UI doesn't honor user time format preferences in day view.
chad accepted this revision.Jul 13 2016, 8:04 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 13 2016, 8:04 PM
epriestley added a comment.Jul 13 2016, 8:05 PM

I guess 8:00 PM is actually 20:00 but that's a transcription error rather than an actual bug.

Closed by commit rP8062423271c7: Respect 12 hour vs 24 hour time formats in Calendar day views (authored by epriestley, committed by epriestley). · Explain WhyJul 13 2016, 10:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
view/
phui/
calendar/
2 lines
webroot/
rsrc/
js/
application/
calendar/
4 lines

Diff 39180

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarDayView.php

Loading...
View Options

webroot/rsrc/js/application/calendar/behavior-day-view.js

Loading...
Phabricator · Built by Phacility