Page MenuHomePhabricator
Differential D16286

Convert Calendar to Modular Transactions
ClosedPublic
Actions

Authored by epriestley on Jul 12 2016, 11:19 PM.
Tags
None
Referenced Files
F13287238: D16286.diff
Tue, Jun 4, 8:30 AM
F13274513: D16286.diff
Fri, May 31, 3:48 AM
F13260565: D16286.diff
Mon, May 27, 12:04 AM
F13246224: D16286.id39160.diff
Thu, May 23, 8:46 AM
F13243001: D16286.diff
Thu, May 23, 3:16 AM
F13221523: D16286.diff
Sun, May 19, 2:50 AM
F13202303: D16286.diff
Tue, May 14, 10:31 PM
F13195432: D16286.diff
Sun, May 12, 10:23 PM
View All Files
Subscribers
None
Tokens
"Cup of Joe" token, awarded by epriestley.

Details

Reviewers
chad
Maniphest Tasks
T9275: Move Calendar to EditEngine
T10633: Render timezones explicitly in email
Commits
rP7b09f5698fe0: Convert Calendar to Modular Transactions
Summary

Ref T9275. Swaps Calendar over to modular transactions. Theoretically, this has almost no effect on anything.

Ref T10633. I didn't actually do anything here yet, but this gets us ready to put timestamps in email.

Test Plan

Created and edited a bunch of events, nothing seemed catastrophically broken.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39160.Jul 12 2016, 11:19 PM
epriestley retitled this revision from to Convert Calendar to Modular Transactions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T10633: Render timezones explicitly in email, T9275: Move Calendar to EditEngine.
epriestley added a comment.Jul 12 2016, 11:21 PM

I think this is the end of the "rewrite everything completely" changes. From here, we should be able to stabilize things and implement features.

epriestley awarded a token.Jul 12 2016, 11:21 PM
chad accepted this revision.Jul 12 2016, 11:58 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 12 2016, 11:58 PM
Closed by commit rP7b09f5698fe0: Convert Calendar to Modular Transactions (authored by epriestley, committed by epriestley). · Explain WhyJul 13 2016, 2:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
34 lines
applications/
calendar/
command/
18 lines
controller/
2 lines
7 lines
6 lines
2 lines
editor/
26 lines
354 lines
storage/
588 lines
xaction/
25 lines
46 lines
46 lines
27 lines
25 lines
42 lines
37 lines
75 lines
44 lines
191 lines
44 lines
44 lines
33 lines
37 lines
4 lines
35 lines
phid/
view/
16 lines
transactions/
storage/
69 lines
infrastructure/
internationalization/
translation/
18 lines

Diff 39173

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/calendar/command/PhabricatorCalendarEventRSVPEmailCommand.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventCancelController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventDragController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventJoinController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...
View Options

src/applications/calendar/editor/PhabricatorCalendarEditEngine.php

Loading...
View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventAcceptTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventAllDayTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventCancelTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventDateTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventDeclineTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventDescriptionTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventEndDateTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventFrequencyTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventIconTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventInviteTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventNameTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventRecurringTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventReplyTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventStartDateTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventTransactionType.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventUntilDateTransaction.php

Loading...
View Options

src/applications/phid/view/PHUIHandleListView.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorModularTransactionType.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...
Phabricator · Built by Phacility