Page MenuHomePhabricator
Differential D16235

Initial cut of CalendarEditEngine
ClosedPublic
Actions

Authored by epriestley on Jul 5 2016, 4:30 PM.
Tags
None
Referenced Files
F13156965: D16235.id39053.diff
Sun, May 5, 8:17 AM
Unknown Object (File)
Mon, Apr 29, 5:10 PM
Unknown Object (File)
Mon, Apr 29, 8:58 AM
Unknown Object (File)
Sun, Apr 28, 5:59 PM
Unknown Object (File)
Wed, Apr 24, 11:40 PM
Unknown Object (File)
Sun, Apr 21, 3:33 PM
Unknown Object (File)
Fri, Apr 19, 5:01 PM
Unknown Object (File)
Thu, Apr 11, 7:57 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9275: Move Calendar to EditEngine
Commits
rP91a8a6d618cb: Initial cut of CalendarEditEngine
Summary

Ref T9275. This builds a Calendar EditEngine which only edits "name".

I'll add more fields, Conduit, etc., and move to modular transactions in future changes.

Test Plan

Used editpro/ URI manually to edit the name of an event.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39053.Jul 5 2016, 4:30 PM
epriestley retitled this revision from to Initial cut of CalendarEditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9275: Move Calendar to EditEngine.
chad accepted this revision.Jul 5 2016, 4:43 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 5 2016, 4:43 PM
Closed by commit rP91a8a6d618cb: Initial cut of CalendarEditEngine (authored by epriestley, committed by epriestley). · Explain WhyJul 13 2016, 2:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
calendar/
application/
2 lines
controller/
12 lines
editor/
74 lines

Diff 39162

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/calendar/application/PhabricatorCalendarApplication.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventEditProController.php

Loading...
View Options

src/applications/calendar/editor/PhabricatorCalendarEditEngine.php

Loading...
Phabricator · Built by Phacility