Make EditEngine form for Calendar Events almost fully-functional
ClosedPublic
Actions

Authored by epriestley on Jul 12 2016, 5:06 PM.

Details

Reviewers

chad

Maniphest Tasks

T9275: Move Calendar to EditEngine

Commits

rPbac6acb3d119: Make EditEngine form for Calendar Events almost fully-functional

Summary

Ref T9275. This still has a number of rough edges and other minor problems (no JS on the controls, some date handling control bugs) but I'll smooth those over in future changes.

It does make all the editable transaction types available from EditEngine, technically speaking.

Test Plan

Created and edited events with the "pro" controller, which mostly worked.

Diff Detail

Repository

rP Phabricator

Branch

calendar7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13033
Build 16654: Run Core Tests
Build 16653: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39154.Jul 12 2016, 5:06 PM

epriestley retitled this revision from to Make EditEngine form for Calendar Events almost fully-functional.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9275: Move Calendar to EditEngine.

chad accepted this revision.Jul 12 2016, 9:32 PM

chad edited edge metadata.

chad added inline comments.

src/applications/calendar/storage/PhabricatorCalendarEvent.php
73	What does @? do?

This revision is now accepted and ready to land.Jul 12 2016, 9:32 PM

'@' makes it interpret the input as an epoch timestamp.

For example, the value 2002 could mean "the year 2002" or "2,002 seconds after Jan 1, 1970". By default, it assumes you mean "the year 2002". If you pass it @2002 instead, it always interprets it as an epoch timestamp.