Page MenuHomePhabricator

Ignore unreachable commits when testing if a repository has imported
ClosedPublic

Authored by epriestley on Jul 11 2016, 3:09 PM.
Tags
None
Referenced Files
F19101972: D16269.diff
Dec 5 2025, 4:47 AM
F19020638: D16269.diff
Nov 23 2025, 5:59 PM
F18866380: D16269.id.diff
Nov 3 2025, 4:51 PM
F18859683: D16269.diff
Nov 2 2025, 4:52 AM
F18780222: D16269.diff
Oct 12 2025, 3:29 AM
F18599557: D16269.diff
Sep 13 2025, 7:41 AM
F18507853: D16269.id.diff
Sep 5 2025, 2:28 AM
F18493902: D16269.diff
Sep 4 2025, 4:50 AM
Subscribers
None

Details

Summary

Fixes T11309. When checking if a repository was fully imported, we incorrectly allow unreachable, un-imported commits to prevent the repository from moving to "Imported".

This can happen if you delete branches from a repository while it is importing.

Instead, ignore unreachable commits when checking for remaining imports, and when reporting status via bin/repository importing.

Test Plan
  • Stopped daemons.
  • Created a new repository and activated it.
  • Ran bin/repository update Rxx.
  • Deleted a branch in the repository.
  • Ran bin/repository update Rxx.
  • Ran daemons to flush queue.

Now:

  • Ran bin/repository importing. Old behavior: showed unreachable commits as importing. New behavior: does not show unreachable commits.
  • Ran bin/repository update. Old behavior: failed to move repository to "imported" status. New behavior: correctly moves repository to "imported" status.

Diff Detail

Repository
rP Phabricator
Branch
perm3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13015
Build 16629: Run Core Tests
Build 16628: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Ignore unreachable commits when testing if a repository has imported.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 11 2016, 3:15 PM
This revision was automatically updated to reflect the committed changes.