Page MenuHomePhabricator

Ignore unreachable commits when testing if a repository has imported
ClosedPublic

Authored by epriestley on Jul 11 2016, 3:09 PM.
Tags
None
Referenced Files
F15481856: D16269.id39141.diff
Tue, Apr 8, 11:54 PM
F15469829: D16269.id.diff
Fri, Apr 4, 4:59 PM
F15466404: D16269.diff
Thu, Apr 3, 5:08 AM
F15403365: D16269.diff
Tue, Mar 18, 3:00 AM
F15387946: D16269.id39141.diff
Sat, Mar 15, 3:08 AM
F15386800: D16269.id.diff
Sat, Mar 15, 1:18 AM
F15383365: D16269.id39136.diff
Fri, Mar 14, 4:24 PM
F15331795: D16269.id39141.diff
Mar 7 2025, 1:48 PM
Subscribers
None

Details

Summary

Fixes T11309. When checking if a repository was fully imported, we incorrectly allow unreachable, un-imported commits to prevent the repository from moving to "Imported".

This can happen if you delete branches from a repository while it is importing.

Instead, ignore unreachable commits when checking for remaining imports, and when reporting status via bin/repository importing.

Test Plan
  • Stopped daemons.
  • Created a new repository and activated it.
  • Ran bin/repository update Rxx.
  • Deleted a branch in the repository.
  • Ran bin/repository update Rxx.
  • Ran daemons to flush queue.

Now:

  • Ran bin/repository importing. Old behavior: showed unreachable commits as importing. New behavior: does not show unreachable commits.
  • Ran bin/repository update. Old behavior: failed to move repository to "imported" status. New behavior: correctly moves repository to "imported" status.

Diff Detail

Repository
rP Phabricator
Branch
perm3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13015
Build 16629: Run Core Tests
Build 16628: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Ignore unreachable commits when testing if a repository has imported.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 11 2016, 3:15 PM
This revision was automatically updated to reflect the committed changes.