Page MenuHomePhabricator
Differential D14654

Unbeta Phame
AbandonedPublic
Actions

Authored by chad on Dec 3 2015, 8:08 PM.
Tags
None
Referenced Files
F15513689: D14654.id35451.diff
Thu, Apr 17, 8:59 PM
F15459815: D14654.diff
Mon, Mar 31, 4:48 PM
F15454358: D14654.id38976.diff
Sat, Mar 29, 6:10 PM
F15451280: D14654.id35451.diff
Fri, Mar 28, 9:11 PM
F15449916: D14654.id35449.diff
Fri, Mar 28, 12:51 PM
F15449450: D14654.id39083.diff
Fri, Mar 28, 10:21 AM
F15444274: D14654.id.diff
Thu, Mar 27, 8:48 AM
F15441282: D14654.diff
Wed, Mar 26, 5:19 PM
View All Files
Subscribers
cburroughs
eadler
Korvin
Luke081515.2

Details

Reviewers
epriestley
Maniphest Tasks
T9360: Unbeta Phame
T9895: Update Phame Documentation
Summary

After next stable cut, perhaps. I think its ready enough. Fixes T9360, Fixes T9895

Test Plan

view app

Diff Detail

Repository
rP Phabricator
Branch
arcpatch-D14654
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12959
Build 16544: Run Core Tests
Build 16543: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35449.Dec 3 2015, 8:08 PM
chad retitled this revision from to Unbeta Phame.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 3 2015, 8:08 PM
chad updated this revision to Diff 35451.Dec 3 2015, 8:34 PM
  • Update Diviner Docs
chad updated this object.Dec 3 2015, 8:36 PM
chad added tasks: T9895: Update Phame Documentation, T9360: Unbeta Phame.
cburroughs added a subscriber: cburroughs.Jan 8 2016, 6:51 PM
Luke081515.2 added a subscriber: Luke081515.2.Jan 14 2016, 9:57 PM
eadler added a subscriber: eadler.Apr 29 2016, 7:57 AM

curious, any reason not to land this?

epriestley edited edge metadata.Apr 29 2016, 12:45 PM

T9897 has the list of things we want to fix before moving Phame out of prototype.

I think this is mostly blocked on me and on custom domains needing some rework to really be usable.

chad updated this revision to Diff 38976.Jun 30 2016, 8:08 PM
chad edited edge metadata.
  • Update docs
epriestley added a comment.Jul 7 2016, 12:28 AM

Some of this language in the doc feels a bit weird and out of date with modern tone/focus, let me take a quick pass at it.

I'll caveat custom domains, too.

epriestley accepted this revision.Jul 7 2016, 1:40 AM
epriestley edited edge metadata.

D16246 for alternate docs.

This revision is now accepted and ready to land.Jul 7 2016, 1:40 AM
chad updated this revision to Diff 39083.Jul 7 2016, 1:46 AM
chad edited edge metadata.
  • Update docs
epriestley added a comment.Jul 7 2016, 1:51 AM

(This looks flipped -- should just be removing isPrototype()?)

chad abandoned this revision.Jul 7 2016, 1:51 AM

somethings messed up locally.

chad added a comment.Jul 7 2016, 1:55 AM

I don't see isPrototype... so .... huzzah?

epriestley added a comment.Jul 7 2016, 1:56 AM

Oh, the earlier version of this snuck into D16245. Looks like we're good now, since D16246 just overwrote the docs anyway.

Revision Contents
Changeset List

PathSize
src/
docs/
user/
userguide/
144 lines

Diff 39083

View Options

src/docs/user/userguide/phame.diviner

Loading...
Phabricator · Built by Phacility