Page MenuHomePhabricator
Differential D16241

Redirect https blogs
ClosedPublic
Actions

Authored by chad on Jul 6 2016, 8:33 PM.
Tags
None
Referenced Files
F15582042: D16241.diff
Wed, May 7, 2:38 PM
F15572602: D16241.id39070.diff
Mon, May 5, 4:46 PM
F15564401: D16241.id39070.diff
Wed, Apr 30, 12:04 PM
F15560424: D16241.id39076.diff
Tue, Apr 29, 2:32 PM
F15555252: D16241.id.diff
Mon, Apr 28, 10:33 AM
F15554931: D16241.id39075.diff
Mon, Apr 28, 9:24 AM
F15549575: D16241.diff
Sun, Apr 27, 6:39 AM
F15516910: D16241.id.diff
Fri, Apr 18, 10:06 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9360: Unbeta Phame
Commits
rPee460b4f1b4c: Redirect https blogs
Summary

Ref T9360, forces https if we say the blog is https.

Test Plan

Fake an https, get redirected.

Diff Detail

Repository
rP Phabricator
Branch
phame-https (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12951
Build 16532: Run Core Tests
Build 16531: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39070.Jul 6 2016, 8:33 PM
chad retitled this revision from to Redirect https blogs.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9360: Unbeta Phame.
Herald added a subscriber: Korvin. · View Herald TranscriptJul 6 2016, 8:33 PM
epriestley requested changes to this revision.Jul 6 2016, 11:25 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phame/site/PhameBlogSite.php
23

I'd expect this to need a $full_uri->getProtocol() here somewhere, the bare $full_uri should never be "https".

This revision now requires changes to proceed.Jul 6 2016, 11:25 PM
chad added a comment.Jul 6 2016, 11:52 PM

I knew I was going to be busted on that test plan. Haha. FWIW I got stumped by the parent Domain bug and never went back to this after fixing.

epriestley added a comment.Jul 6 2016, 11:56 PM

I can kick the tires locally before I accept, I have it sort-of-configured locally.

chad updated this revision to Diff 39075.Jul 7 2016, 12:19 AM
chad edited edge metadata.
  • check protocol, rerun test, see redirect
epriestley accepted this revision.Jul 7 2016, 12:20 AM
epriestley edited edge metadata.

Cool, this works properly in my only-sort-of-fake local environment:

Screen Shot 2016-07-06 at 5.20.08 PM.png (1×1 px, 344 KB)

This revision is now accepted and ready to land.Jul 7 2016, 12:20 AM
Closed by commit rPee460b4f1b4c: Redirect https blogs (authored by chad, committed by chad). · Explain WhyJul 7 2016, 12:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phame/
site/
7 lines

Diff 39075

View Options

src/applications/phame/site/PhameBlogSite.php

Loading...
Phabricator · Built by Phacility