Page MenuHomePhabricator
Differential D16242

Clean up parentDomain issues in PhameBlog
ClosedPublic
Actions

Authored by chad on Jul 6 2016, 8:46 PM.
Tags
None
Referenced Files
F13230224: D16242.id.diff
Mon, May 20, 10:05 PM
F13204127: D16242.diff
Wed, May 15, 12:21 AM
F13186924: D16242.diff
Sat, May 11, 4:13 AM
F13175891: D16242.diff
Wed, May 8, 8:29 AM
Unknown Object (File)
Tue, May 7, 7:17 AM
Unknown Object (File)
Fri, May 3, 7:22 PM
Unknown Object (File)
Fri, May 3, 5:48 AM
Unknown Object (File)
Fri, Apr 26, 2:14 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9360: Unbeta Phame
Commits
rP3bed16e750f0: Clean up parentDomain issues in PhameBlog
Summary

Ref T9360. These weren't getting set properly, also make them nullable since they're optional.

Test Plan

run upgrade, make a new blog with and without a parent domain. Edit a current blog.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 39071.Jul 6 2016, 8:46 PM
chad retitled this revision from to Clean up parentDomain issues in PhameBlog.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9360: Unbeta Phame.
Herald added a subscriber: Korvin. · View Herald TranscriptJul 6 2016, 8:46 PM
epriestley accepted this revision.Jul 6 2016, 11:25 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 6 2016, 11:25 PM
Closed by commit rP3bed16e750f0: Clean up parentDomain issues in PhameBlog (authored by chad, committed by chad). · Explain WhyJul 7 2016, 12:02 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T11320: AphrontQueryException on Phame when creating new blog without Full Domain URI.Jul 12 2016, 8:00 PM

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
2 lines
src/
applications/
phame/
editor/
1 line
storage/
4 lines

Diff 39073

View Options

resources/sql/autopatches/20160706.phame.blog.parentdomain.2.sql

Loading...
View Options

resources/sql/autopatches/20160706.phame.blog.parentsite.1.sql

Loading...
View Options

src/applications/phame/editor/PhameBlogEditor.php

Loading...
View Options

src/applications/phame/storage/PhameBlog.php

Loading...
Phabricator · Built by Phacility