Paths

Table of Contentst

Differential D16241

Redirect https blogs
ClosedPublic
Actions

Authored by chad on Jul 6 2016, 8:33 PM.

Tags

None

Referenced Files

	F15286005: D16241.diff
	Tue, Mar 4, 5:26 PM

	Unknown Object (File)
	Mon, Mar 3, 12:35 AM

	Unknown Object (File)
	Sun, Feb 9, 1:57 AM

	Unknown Object (File)
	Sat, Feb 8, 5:38 AM

	Unknown Object (File)
	Fri, Feb 7, 12:54 AM

	Unknown Object (File)
	Jan 31 2025, 1:57 AM

	Unknown Object (File)
	Jan 24 2025, 2:34 PM

	Unknown Object (File)
	Jan 21 2025, 11:07 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T9360: Unbeta Phame

Commits

rPee460b4f1b4c: Redirect https blogs

Summary

Ref T9360, forces https if we say the blog is https.

Test Plan

Fake an https, get redirected.

Diff Detail

Repository

Branch

phame-https (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12946
Build 16524: Run Core Tests
Build 16523: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	63 ms	PhabricatorProjectCoreTestCase::Unknown Unit Message ("") Assertion failed, expected 'true' (at PhabricatorProjectCoreTestCase.php:1118). ACTUAL VALUE
	0 ms	AlmanacNamesTestCase::Unknown Unit Message ("") 30 assertions passed.
	0 ms	AlmanacServiceTypeTestCase::Unknown Unit Message ("") 1 assertion passed.
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("") 4 assertions passed.
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("") 1 assertion passed.
		View Full Test Results (1 Failed · 326 Passed)

Event Timeline

chad updated this revision to Diff 39070.Jul 6 2016, 8:33 PM

chad retitled this revision from to Redirect https blogs.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T9360: Unbeta Phame.

Herald added a subscriber: Korvin. · View Herald TranscriptJul 6 2016, 8:33 PM

epriestley requested changes to this revision.Jul 6 2016, 11:25 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/phame/site/PhameBlogSite.php
23	I'd expect this to need a `$full_uri->getProtocol()` here somewhere, the bare `$full_uri` should never be `"https"`.

This revision now requires changes to proceed.Jul 6 2016, 11:25 PM

I knew I was going to be busted on that test plan. Haha. FWIW I got stumped by the parent Domain bug and never went back to this after fixing.

I can kick the tires locally before I accept, I have it sort-of-configured locally.

check protocol, rerun test, see redirect

Cool, this works properly in my only-sort-of-fake local environment:

Screen Shot 2016-07-06 at 5.20.08 PM.png (1×1 px, 344 KB)

This revision is now accepted and ready to land.Jul 7 2016, 12:20 AM

Closed by commit rPee460b4f1b4c: Redirect https blogs (authored by chad, committed by chad). · Explain WhyJul 7 2016, 12:22 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

site/

PhameBlogSite.php

7 lines

Diff 39070

src/applications/phame/site/PhameBlogSite.php

Loading...