Differential D16229

Fix impropery history graph trace in Mercurial
ClosedPublic
Actions

Authored by epriestley on Jul 4 2016, 5:23 PM.

Details

Reviewers

chad

Maniphest Tasks

T11267: Commit graph broken for Mercurial repositories

Commits

rP2a1393c008c3: Fix impropery history graph trace in Mercurial

Summary

Fixes T11267. This data was coming back weird (in reverse order relative to the graph itself). Previously it worked OK anyway, but the new logic is a little more sensitive to the input.

Test Plan

Viewed a Mercurial repository with linear history, saw linear history.

Diff Detail

Repository

rP Phabricator

Branch

hghistory1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12920
Build 16484: Run Core Tests
Build 16483: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39037.Jul 4 2016, 5:23 PM

epriestley retitled this revision from to Fix impropery history graph trace in Mercurial.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11267: Commit graph broken for Mercurial repositories.

chad accepted this revision.Jul 4 2016, 5:23 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jul 4 2016, 5:23 PM

Closed by commit rP2a1393c008c3: Fix impropery history graph trace in Mercurial (authored by epriestley, committed by epriestley). · Explain WhyJul 4 2016, 5:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

conduit/

DiffusionHistoryQueryConduitAPIMethod.php

2 lines

Diff 39037

View Options

src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php

Fix impropery history graph trace in MercurialClosedPublicActions