Page MenuHomePhabricator

Make i18n string extraction faster and more flexible
ClosedPublic

Authored by epriestley on Jul 4 2016, 1:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 10:34 PM
Unknown Object (File)
Sun, Dec 8, 7:24 PM
Unknown Object (File)
Sun, Dec 8, 7:24 PM
Unknown Object (File)
Sun, Dec 8, 7:23 PM
Unknown Object (File)
Sun, Dec 8, 7:22 PM
Unknown Object (File)
Sun, Dec 8, 6:46 PM
Unknown Object (File)
Sat, Dec 7, 3:12 PM
Unknown Object (File)
Sat, Dec 7, 3:12 PM
Subscribers
None
Tokens
"Hungry Hippo" token, awarded by epriestley."Y So Serious" token, awarded by chad.

Details

Summary

Ref T5267. Two general changes:

  • Make string extraction use a cache, so that it doesn't take several minutes every time you change something. Minor updates now only take a few seconds (like arc liberate and similar).
  • Instead of dumping a sort-of-template file out, write out to a cache (src/.cache/i18n_strings.json). I'm planning to add more steps to read this cache and do interesting things with it (emit translatewiki strings, generate or update standalone translation files, etc).
Test Plan
  • Ran bin/i18n extract.
  • Ran it again, saw it go a lot faster.
  • Changed stuff, ran it, saw it only look at new stuff.
  • Examined caches.

Diff Detail

Repository
rP Phabricator
Branch
i18n1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12916
Build 16478: Run Core Tests
Build 16477: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Make i18n string extraction faster and more flexible.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 4 2016, 1:39 AM
This revision was automatically updated to reflect the committed changes.