Page MenuHomePhabricator
Differential D16219

Make closed vs open objects in object graphs more obvious
ClosedPublic
Actions

Authored by epriestley on Jul 1 2016, 7:55 PM.
Tags
None
Referenced Files
F14813075: D16219.diff
Mon, Jan 27, 9:54 AM
Unknown Object (File)
Fri, Jan 24, 2:29 PM
Unknown Object (File)
Mon, Jan 20, 11:35 AM
Unknown Object (File)
Sat, Jan 18, 3:36 AM
Unknown Object (File)
Sat, Dec 28, 4:19 PM
Unknown Object (File)
Dec 23 2024, 7:32 PM
Unknown Object (File)
Dec 11 2024, 11:28 AM
Unknown Object (File)
Dec 9 2024, 6:10 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4788: Allow "Edit Dependencies" both ways (blocking and depending)
Commits
rP962cae22b767: Make closed vs open objects in object graphs more obvious
Summary

Ref T4788. It's not easy to tell at a glance which objects are open vs closed. Try to make that a bit more clear. This could probably use some more tweaking.

Test Plan

Screen Shot 2016-07-01 at 12.53.20 PM.png (303×440 px, 35 KB)

Diff Detail

Repository
rP Phabricator
Branch
graph7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12894
Build 16446: Run Core Tests
Build 16445: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39017.Jul 1 2016, 7:55 PM
epriestley retitled this revision from to Make closed vs open objects in object graphs more obvious.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4788: Allow "Edit Dependencies" both ways (blocking and depending).
Herald edited edge metadata. · View Herald TranscriptJul 1 2016, 7:55 PM
chad accepted this revision.Jul 1 2016, 7:56 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2016, 7:56 PM
Closed by commit rP962cae22b767: Make closed vs open objects in object graphs more obvious (authored by epriestley, committed by epriestley). · Explain WhyJul 1 2016, 7:56 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Jul 1 2016, 7:57 PM

I also believe we set icon color = grey in all UI cases?

epriestley mentioned this in D16220: Set Maniphest status icons to grey for closed tasks in object graph view.Jul 1 2016, 8:00 PM
epriestley mentioned this in rPd3c327ec9355: Set Maniphest status icons to grey for closed tasks in object graph view.Jul 1 2016, 8:01 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
infrastructure/
graph/
8 lines
8 lines
19 lines
webroot/
rsrc/
css/
aphront/
15 lines

Diff 39017

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/graph/DifferentialRevisionGraph.php

Loading...
View Options

src/infrastructure/graph/ManiphestTaskGraph.php

Loading...
View Options

src/infrastructure/graph/PhabricatorObjectGraph.php

Loading...
View Options

webroot/rsrc/css/aphront/table-view.css

Loading...
Phabricator · Built by Phacility