Differential D16211

New Tokens
ClosedPublic
Actions

Authored by chad on Jul 1 2016, 4:10 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T11244: Identify additional tokens to add to Phabricator

Commits

rP95b1a89e5cff: New Tokens

Summary

New tokens, slightly larger (18x18 vs 16x16). I think these all feel decent, I might tweak the thumbs icons a little more color-wise.

Test Plan

Use Tokens.

Diff Detail

Repository

rP Phabricator

Branch

tokens (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12873
Build 16413: Run Core Tests
Build 16412: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 38996.Jul 1 2016, 4:10 AM

chad retitled this revision from to New Tokens.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptJul 1 2016, 4:10 AM

chad added a task: T11244: Identify additional tokens to add to Phabricator.Jul 1 2016, 4:11 AM

chad edited the test plan for this revision. (Show Details)

chad added inline comments.

webroot/rsrc/image/sprite-tokens.png
1	haha. oh. I don't want to make two sizes anymore and only build retina images. hrm.

Add 1x icons proper like

The thumbs up / thumbs down are a bit hard for me to see against a light background.

This revision is now accepted and ready to land.Jul 1 2016, 11:34 AM

I took one pass at re-coloring it and it was much better, but may need a second pass. Wanted to see it live for a bit.

Closed by commit rP95b1a89e5cff: New Tokens (authored by chad, committed by chad). · Explain WhyJul 1 2016, 2:12 PM

This revision was automatically updated to reflect the committed changes.

{F1707956}

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

14 lines

sprite/

manifest/

tokens.json

34 lines

tokens_1x/

tokens_2x/

src/

applications/

celerity/

CeleritySpriteGenerator.php

2 lines

webroot/

rsrc/

css/

phui/

phui-icon.css

4 lines

sprite-tokens.css

32 lines

image/

sprite-tokens-X2.png

sprite-tokens.png

Diff 38996

View Options

resources/celerity/map.php

View Options

resources/sprite/manifest/tokens.json

View Options

resources/sprite/tokens_1x/coin-1.png

View Options

resources/sprite/tokens_1x/coin-2.png

View Options

resources/sprite/tokens_1x/coin-3.png

View Options

resources/sprite/tokens_1x/coin-4.png

View Options

resources/sprite/tokens_1x/heart-1.png

View Options

resources/sprite/tokens_1x/heart-2.png

View Options

resources/sprite/tokens_1x/like-1.png

View Options

resources/sprite/tokens_1x/like-2.png

View Options

resources/sprite/tokens_1x/medal-1.png

View Options

resources/sprite/tokens_1x/medal-2.png

View Options

resources/sprite/tokens_1x/medal-3.png

View Options

resources/sprite/tokens_1x/medal-4.png

View Options

resources/sprite/tokens_1x/misc-1.png

View Options

resources/sprite/tokens_1x/misc-2.png

View Options

resources/sprite/tokens_1x/misc-3.png

View Options

resources/sprite/tokens_1x/misc-4.png

View Options

resources/sprite/tokens_2x/coin-1.png

View Options

resources/sprite/tokens_2x/coin-2.png

View Options

resources/sprite/tokens_2x/coin-3.png

View Options

resources/sprite/tokens_2x/coin-4.png

View Options

resources/sprite/tokens_2x/heart-1.png

View Options

resources/sprite/tokens_2x/heart-2.png

View Options

resources/sprite/tokens_2x/like-1.png

View Options

resources/sprite/tokens_2x/like-2.png

View Options

resources/sprite/tokens_2x/medal-1.png

View Options

resources/sprite/tokens_2x/medal-2.png

View Options

resources/sprite/tokens_2x/medal-3.png

View Options

resources/sprite/tokens_2x/medal-4.png

View Options

resources/sprite/tokens_2x/misc-1.png

View Options

resources/sprite/tokens_2x/misc-2.png

View Options

resources/sprite/tokens_2x/misc-3.png

View Options

resources/sprite/tokens_2x/misc-4.png

View Options

src/applications/celerity/CeleritySpriteGenerator.php

View Options

webroot/rsrc/css/phui/phui-icon.css

View Options

webroot/rsrc/css/sprite-tokens.css

View Options

webroot/rsrc/image/sprite-tokens-X2.png

View Options

webroot/rsrc/image/sprite-tokens.png

New TokensClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38996

resources/celerity/map.php

resources/sprite/manifest/tokens.json

resources/sprite/tokens_1x/coin-1.png

resources/sprite/tokens_1x/coin-2.png

resources/sprite/tokens_1x/coin-3.png

resources/sprite/tokens_1x/coin-4.png

resources/sprite/tokens_1x/heart-1.png

resources/sprite/tokens_1x/heart-2.png

resources/sprite/tokens_1x/like-1.png

resources/sprite/tokens_1x/like-2.png

resources/sprite/tokens_1x/medal-1.png

resources/sprite/tokens_1x/medal-2.png

resources/sprite/tokens_1x/medal-3.png

resources/sprite/tokens_1x/medal-4.png

resources/sprite/tokens_1x/misc-1.png

resources/sprite/tokens_1x/misc-2.png

resources/sprite/tokens_1x/misc-3.png

resources/sprite/tokens_1x/misc-4.png

resources/sprite/tokens_2x/coin-1.png

resources/sprite/tokens_2x/coin-2.png

resources/sprite/tokens_2x/coin-3.png

resources/sprite/tokens_2x/coin-4.png

resources/sprite/tokens_2x/heart-1.png

resources/sprite/tokens_2x/heart-2.png

resources/sprite/tokens_2x/like-1.png

resources/sprite/tokens_2x/like-2.png

resources/sprite/tokens_2x/medal-1.png

resources/sprite/tokens_2x/medal-2.png

resources/sprite/tokens_2x/medal-3.png

resources/sprite/tokens_2x/medal-4.png

resources/sprite/tokens_2x/misc-1.png

resources/sprite/tokens_2x/misc-2.png

resources/sprite/tokens_2x/misc-3.png

resources/sprite/tokens_2x/misc-4.png

src/applications/celerity/CeleritySpriteGenerator.php

webroot/rsrc/css/phui/phui-icon.css

webroot/rsrc/css/sprite-tokens.css

webroot/rsrc/image/sprite-tokens-X2.png

webroot/rsrc/image/sprite-tokens.png

New Tokens
ClosedPublic
Actions

Revision Contents
Changeset List