Page MenuHomePhabricator

Fix a CSRF issue with adding new email addresses
ClosedPublic

Authored by epriestley on Jun 30 2016, 3:25 PM.
Tags
None
Referenced Files
F19060569: D16200.diff
Nov 29 2025, 9:41 AM
F18994122: D16200.id38965.diff
Nov 19 2025, 10:11 AM
F18993319: D16200.diff
Nov 19 2025, 7:45 AM
F18830103: D16200.id.diff
Oct 25 2025, 4:12 AM
F18827453: D16200.diff
Oct 24 2025, 10:09 AM
F18779385: D16200.id.diff
Oct 11 2025, 1:43 PM
F18774242: D16200.id38965.diff
Oct 9 2025, 6:05 PM
F18733381: D16200.id.diff
Sep 30 2025, 10:33 PM
Subscribers
None

Details

Summary

The first dialog was being given the wrong user ($user, should be $viewer), leading to a CSRF issue.

(The CSRF token it generated was invalid in all validation contexts, so this wasn't a security problem or a way to capture CSRF tokens for other users.)

Use newDialog() instead.

(This seems completely unrelated to the vaguely-similar-looking issues we saw earlier this week.)

Test Plan
  • Added a new email address.
  • Clicked "Done" on the last step.
  • Completed workflow instead of getting a CSRF error.

Diff Detail

Repository
rP Phabricator
Branch
csrf1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12841
Build 16363: Run Core Tests
Build 16362: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix a CSRF issue with adding new email addresses.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
tide added a reviewer: tide.
This revision is now accepted and ready to land.Jun 30 2016, 3:31 PM
This revision was automatically updated to reflect the committed changes.