Page MenuHomePhabricator

Validate Arcanist install-certificate URIs more carefully
ClosedPublic

Authored by epriestley on Jun 28 2016, 9:45 PM.
Tags
None
Referenced Files
F15432703: D16188.id.diff
Mon, Mar 24, 7:29 PM
F15427879: D16188.diff
Sun, Mar 23, 4:39 PM
F15409916: D16188.id38943.diff
Wed, Mar 19, 5:55 AM
F15409573: D16188.id38943.diff
Wed, Mar 19, 4:43 AM
F15409171: D16188.id38943.diff
Wed, Mar 19, 3:31 AM
F15408945: D16188.id38943.diff
Wed, Mar 19, 2:18 AM
F15408755: D16188.id38943.diff
Wed, Mar 19, 1:06 AM
F15408568: D16188.id38943.diff
Tue, Mar 18, 11:53 PM
Subscribers
None

Details

Summary

Fixes T11222. This was lazy-future-proofed for Conduit SSH support, but users are boundlessly creative. Check protocols explicitly.

Test Plan
$ arc install-certificate a.b:1/
Usage Exception: Server URI "a.b:1/" must include the "http" or "https" protocol. It should be in the form "https://phabricator.example.com/".
  • Also went through a successful workflow with a URI in the form provided in the example.

Diff Detail

Repository
rARC Arcanist
Branch
badinstall
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12817
Build 16329: Run Core Tests
Build 16328: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Validate Arcanist install-certificate URIs more carefully.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 28 2016, 10:15 PM
This revision was automatically updated to reflect the committed changes.