Page MenuHomePhabricator

Validate Arcanist install-certificate URIs more carefully
ClosedPublic

Authored by epriestley on Jun 28 2016, 9:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 7:58 AM
Unknown Object (File)
Sun, Dec 15, 5:30 PM
Unknown Object (File)
Thu, Dec 5, 12:47 PM
Unknown Object (File)
Tue, Nov 26, 6:23 PM
Unknown Object (File)
Sat, Nov 23, 3:41 AM
Unknown Object (File)
Nov 5 2024, 11:24 PM
Unknown Object (File)
Nov 5 2024, 11:23 PM
Unknown Object (File)
Nov 5 2024, 11:23 PM
Subscribers
None

Details

Summary

Fixes T11222. This was lazy-future-proofed for Conduit SSH support, but users are boundlessly creative. Check protocols explicitly.

Test Plan
$ arc install-certificate a.b:1/
Usage Exception: Server URI "a.b:1/" must include the "http" or "https" protocol. It should be in the form "https://phabricator.example.com/".
  • Also went through a successful workflow with a URI in the form provided in the example.

Diff Detail

Repository
rARC Arcanist
Branch
badinstall
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12817
Build 16329: Run Core Tests
Build 16328: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Validate Arcanist install-certificate URIs more carefully.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 28 2016, 10:15 PM
This revision was automatically updated to reflect the committed changes.