Differential D16187

Disambiguate "host.com:123" as a port, not a relative path
ClosedPublic
Actions

Authored by epriestley on Jun 28 2016, 9:40 PM.

Details

Reviewers

chad

Maniphest Tasks

T11222: arc hitting wrong url for conduit when not passed a full URI

Commits

rPHUe9e79fd8d7f5: Disambiguate "host.com:123" as a port, not a relative path

Summary

Ref T11222. When we parse "host.com:123", it could be a Git-style URI pointing at the file named "123" on the host. We currently interpret it as such.

Instead, always assume that completely numeric "paths" are port numbers.

Test Plan

Added failing test; made it pass.

Diff Detail

Repository

rPHU libphutil

Branch

uriport

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12816
Build 16327: Run Core Tests
Build 16326: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38937.Jun 28 2016, 9:40 PM

epriestley retitled this revision from to Disambiguate "host.com:123" as a port, not a relative path.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11222: arc hitting wrong url for conduit when not passed a full URI.

chad accepted this revision.Jun 28 2016, 9:43 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 28 2016, 9:43 PM

Closed by commit rPHUe9e79fd8d7f5: Disambiguate "host.com:123" as a port, not a relative path (authored by epriestley, committed by epriestley). · Explain WhyJun 28 2016, 9:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

PhutilURI.php

7 lines

__tests__/

PhutilURITestCase.php

8 lines

Diff 38937

View Options

src/parser/PhutilURI.php

View Options

src/parser/tests/PhutilURITestCase.php

Disambiguate "host.com:123" as a port, not a relative pathClosedPublicActions