Handle Subversion SSH on nonstandard ports
ClosedPublic
Actions

Authored by epriestley on Jun 23 2016, 2:35 PM.

Details

Reviewers

chad

Maniphest Tasks

T11203: Observing svn+ssh on non-standard ssh port

Commits

rP70463e8a16d4: Handle Subversion SSH on nonstandard ports

Summary

Fixes T11203. Subversion handling of SVN_SSH commands requires some additional finesse for nonstandard remote SSH ports.

We get domain.com:port in the command, so parse it out if it's present.

Test Plan

@enckse confirmed this locally in T11203.

Diff Detail

Repository

rP Phabricator

Branch

sshport

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12784
Build 16274: Run Core Tests
Build 16273: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38903.Jun 23 2016, 2:35 PM

epriestley retitled this revision from to Handle Subversion SSH on nonstandard ports.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11203: Observing svn+ssh on non-standard ssh port.

epriestley added a subscriber: enckse.

chad accepted this revision.Jun 23 2016, 2:36 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 23 2016, 2:36 PM

Closed by commit rP70463e8a16d4: Handle Subversion SSH on nonstandard ports (authored by epriestley, committed by epriestley). · Explain WhyJun 23 2016, 2:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

scripts/

ssh/

ssh-connect.php

19 lines

Diff 38903

View Options

scripts/ssh/ssh-connect.php

Handle Subversion SSH on nonstandard portsClosedPublicActions