Page MenuHomePhabricator

Log and continue when trying to destroy edges with no edge definition
ClosedPublic

Authored by epriestley on Jun 23 2016, 12:16 PM.
Tags
None
Referenced Files
F19814747: D16171.diff
Wed, Mar 4, 3:24 PM
F19531808: D16171.id38902.diff
Jan 20 2026, 7:12 AM
F19350614: D16171.id38901.diff
Dec 26 2025, 3:33 AM
F19275745: D16171.diff
Dec 23 2025, 12:47 AM
F19098786: D16171.diff
Dec 4 2025, 6:06 PM
F18994124: D16171.id38901.diff
Nov 19 2025, 10:11 AM
F18783578: D16171.id38901.diff
Oct 13 2025, 8:14 AM
F18739362: D16171.id.diff
Oct 1 2025, 9:06 PM
Subscribers
None

Details

Summary

Fixes T11201.

Test Plan

Created bogus edges like this:

INSERT INTO edge (src, type, dst, dateCreated, seq) values ('PHID-TASK-vnddativbialb5p6ymis', 999999, 'quack', UNIX_TIMESTAMP(), 1);

Then ran bin/remove destroy on the relevant object.

Before the patch, destruction halted after hittin the bad edge.

After the patch, a warning is emitted but destruction continues.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Log and continue when trying to destroy edges with no edge definition.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 23 2016, 1:45 PM
This revision was automatically updated to reflect the committed changes.