Paths

Table of Contentst

Differential D16171

Log and continue when trying to destroy edges with no edge definition
ClosedPublic
Actions

Authored by epriestley on Jun 23 2016, 12:16 PM.

Details

Reviewers

chad

Maniphest Tasks

T11201: Exception when destroying an object with edges that no longer have corresponding edge definitions

Commits

rPa2cb5e134755: Log and continue when trying to destroy edges with no edge definition

Summary

Fixes T11201.

Test Plan

Created bogus edges like this:

INSERT INTO edge (src, type, dst, dateCreated, seq) values ('PHID-TASK-vnddativbialb5p6ymis', 999999, 'quack', UNIX_TIMESTAMP(), 1);

Then ran bin/remove destroy on the relevant object.

Before the patch, destruction halted after hittin the bad edge.

After the patch, a warning is emitted but destruction continues.

Diff Detail

Repository

rP Phabricator

Branch

rmedge1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12782
Build 16271: Run Core Tests
Build 16270: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38901.Jun 23 2016, 12:16 PM

epriestley retitled this revision from to Log and continue when trying to destroy edges with no edge definition.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11201: Exception when destroying an object with edges that no longer have corresponding edge definitions.

epriestley mentioned this in T11201: Exception when destroying an object with edges that no longer have corresponding edge definitions.Jun 23 2016, 12:18 PM

chad accepted this revision.Jun 23 2016, 1:45 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 23 2016, 1:45 PM

Closed by commit rPa2cb5e134755: Log and continue when trying to destroy edges with no edge definition (authored by epriestley, committed by epriestley). · Explain WhyJun 23 2016, 1:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

edges/

engineextension/

PhabricatorEdgesDestructionEngineExtension.php

12 lines

Diff 38901

View Options

src/infrastructure/edges/engineextension/PhabricatorEdgesDestructionEngineExtension.php

Log and continue when trying to destroy edges with no edge definitionClosedPublicActions