Allow Herald text list fields to use "Exists" / "Does not exist" conditions
ClosedPublic
Actions

Authored by epriestley on Jun 21 2016, 4:21 PM.

Details

Reviewers

chad

Commits

rPf38730aab88e: Allow Herald text list fields to use "Exists" / "Does not exist" conditions

Summary

This makes it more natural to write Herald rules about commits that appear on any or no branches.

Test Plan

Wrote a commit rule for commits on any branch, ran it with bin/repository reparse --herald <commit>, saw expected results in web UI.

Diff Detail

Repository

rP Phabricator

Branch

herald1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12752
Build 16226: Run Core Tests
Build 16225: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38871.Jun 21 2016, 4:21 PM

epriestley retitled this revision from to Allow Herald text list fields to use "Exists" / "Does not exist" conditions.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

The other field type which uses this is "Affected Files" (for commits and revisions).

(It probably isn't too useful there, but shouldn't hurt anything, and I suppose you could write a commits rule to forbid empty commits.)

chad accepted this revision.Jun 21 2016, 5:20 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 21 2016, 5:20 PM

Closed by commit rPf38730aab88e: Allow Herald text list fields to use "Exists" / "Does not exist" conditions (authored by epriestley, committed by epriestley). · Explain WhyJun 21 2016, 10:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

field/

HeraldField.php

10 lines

Diff 38871

View Options

src/applications/herald/field/HeraldField.php

Allow Herald text list fields to use "Exists" / "Does not exist" conditionsClosedPublicActions