Paths

Table of Contentst

Don't track "phabricator/" staging area tags
ClosedPublic
Actions

Authored by epriestley on Jun 16 2016, 5:57 PM.

Details

Reviewers

Maniphest Tasks

T6878: Tagged commits which are not ancestors of any branch head don't get imported
T9028: Phabricator handles commits which are published and later deleted poorly

Commits

rP7c8f9d7ba26c: Don't track "phabricator/" staging area tags

Summary

Ref T9028. Ref T6878. This rule should probably be refined in the long term, but for now just ignore "phabricator/diff/12424" and similar staging area tags.

Test Plan

Ran bin/repository discover --verbose on a repository with staging area refs, saw Phabricator ignore those refs as untracked.

Diff Detail

Repository

rP Phabricator

Branch

ref6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12689
Build 16135: Run Core Tests
Build 16134: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38812.Jun 16 2016, 5:57 PM

epriestley retitled this revision from to Don't track "phabricator/" staging area tags.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T9028: Phabricator handles commits which are published and later deleted poorly, T6878: Tagged commits which are not ancestors of any branch head don't get imported.

epriestley mentioned this in T6878: Tagged commits which are not ancestors of any branch head don't get imported.Jun 16 2016, 5:59 PM

chad accepted this revision.Jun 16 2016, 6:11 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 16 2016, 6:11 PM

Closed by commit rP7c8f9d7ba26c: Don't track "phabricator/" staging area tags (authored by epriestley, committed by epriestley). · Explain WhyJun 16 2016, 6:22 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T9028: Phabricator handles commits which are published and later deleted poorly.Jun 16 2016, 6:49 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

data/

DiffusionRepositoryRef.php

5 lines

repository/

storage/

PhabricatorRepository.php

7 lines

Diff 38812

View Options

src/applications/diffusion/data/DiffusionRepositoryRef.php