Differential D16117

Remove "re prefix" and "vary subjects" config
ClosedPublic
Actions

Authored by epriestley on Jun 14 2016, 6:30 PM.

Details

Reviewers

chad

Maniphest Tasks

T11098: Feedback and Errata for Global Settings

Commits

rPcb7560d30172: Remove "re prefix" and "vary subjects" config

Summary

Ref T11098. There is no reason to maintain these as separate values now that they can be configured in global settings.

Test Plan

Hit and read setup issue.
Fiddled with settings.
I'll vet this more throughly in the next diff since I need to fix an issue with global defaults in mail and can explicitly test this at the same time.

Diff Detail

Repository

rP Phabricator

Branch

gpref1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12654
Build 16078: Run Core Tests
Build 16077: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38777.Jun 14 2016, 6:30 PM

epriestley retitled this revision from to Remove "re prefix" and "vary subjects" config.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11098: Feedback and Errata for Global Settings.

chad accepted this revision.Jun 14 2016, 6:31 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 14 2016, 6:31 PM

Also default "Re Prefix" to "no prefix", which is more consistent with the old behavior.

should there be a migration or is the admin supposed to reconfigure these?

I'll provide guidance in the changelog and you'll get a setup warning, but you should reconfigure them. If you've set both, we can't guess which you mean (and I'd guess 99% of installs use the defaults).

Closed by commit rPcb7560d30172: Remove "re prefix" and "vary subjects" config (authored by epriestley, committed by epriestley). · Explain WhyJun 14 2016, 7:35 PM

This revision was automatically updated to reflect the committed changes.