Page MenuHomePhabricator

Fix construction of default settings for users with no settings at all
ClosedPublic

Authored by epriestley on Jun 13 2016, 10:23 PM.
Tags
None
Referenced Files
F13995624: D16112.diff
Wed, Oct 23, 2:18 PM
F13989339: D16112.diff
Mon, Oct 21, 7:50 PM
F13986733: D16112.diff
Mon, Oct 21, 5:07 AM
F13979101: D16112.id38769.diff
Oct 19 2024, 2:39 AM
F13978894: D16112.id38766.diff
Oct 19 2024, 1:33 AM
F13975797: D16112.id.diff
Oct 18 2024, 11:40 AM
F13973819: D16112.diff
Oct 18 2024, 2:49 AM
F13960531: D16112.id38767.diff
Oct 14 2024, 11:51 PM
Subscribers
None

Details

Summary

Ref T11098. Users with at least one setting set correctly fall back to the defaults, but users with no settings at all currently do not.

Make them fall back to global defaults properly.

Test Plan
  • Set global defaults to some non-default setting.
  • Completely delete a user's settings.
  • bin/cache purge --purge-all or --purge-user.
  • View settings as the user.
    • Before change: showed hard-coded defaults instead of global defaults until you save anything.
    • After change: properly shows global defaults from the start.

Diff Detail

Repository
rP Phabricator
Branch
prefs1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12644
Build 16062: Run Core Tests
Build 16061: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix construction of default settings for users with no settings at all.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Very slight simplification.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 13 2016, 10:35 PM
epriestley edited edge metadata.
  • Fix a unit test issue for installs with no global settings.
This revision was automatically updated to reflect the committed changes.