Ref T9897. Adds ability to Archive a Phame Post (only visible under ApplicationSearch).
Details
- Reviewers
epriestley - Maniphest Tasks
- T9897: Unbeta Feedback on Phame
- Commits
- rP72c57d36a30c: Ability to archive Phame Posts
Archive a post, re-publish it, search for it, archive it again. View Home, Blog, Live pages.
Diff Detail
- Repository
- rP Phabricator
- Branch
- phame-archived (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 12621 Build 16026: Run Core Tests Build 16025: arc lint + arc unit
Event Timeline
Can you give this a second glance, I want to make sure I'm not leaking visibility anywhere.
Hrrm -- some of the text (not all of which is new here) is misleading because it says "only you" and "won't be visible to members of this blog", but the actual policy we implement is that users who can edit a blog can see all the drafts and archived posts, so it's not "only you" but "only editors of this blog".
This isn't really new either, but when viewing a blog, there's no easy/obvious way to see archived posts -- for example, no link to "view all posts" in the action menu. You can get to them, sort of, but have to go Phame → View All (Posts) → (no way to query by blog or by archived, except left-nav filter). It would be nice to add a blog typeahead here to let you search by blog, and have the blog action menu link to it.
Everything else looks good to me. Actual policy implementation is fine, some of the messaging around it is just a bit misleading.
src/applications/phame/query/PhamePostSearchEngine.php | ||
---|---|---|
34–38 | probably include archived as an option here? |