Page MenuHomePhabricator

Improve some typeahead matching behaviors
ClosedPublic

Authored by epriestley on Jun 9 2016, 8:16 PM.
Tags
None
Referenced Files
F13284142: D16094.id38720.diff
Mon, Jun 3, 12:52 AM
F13282328: D16094.diff
Sun, Jun 2, 11:57 AM
F13244135: D16094.diff
Thu, May 23, 4:33 AM
F13236016: D16094.diff
Tue, May 21, 7:37 AM
F13229403: D16094.diff
Mon, May 20, 4:16 PM
F13222567: D16094.diff
Sun, May 19, 3:46 AM
F13208741: D16094.id38720.diff
Thu, May 16, 6:59 PM
F13205258: D16094.diff
Wed, May 15, 1:45 AM
Subscribers
None

Details

Summary

Ref T8510. Sort prefix matches above non-prefix matches, so that "Ape Discovery" does not match "discovery" better than "Discovery".

Sort functions last.

Rename function internal strings so they don't get over-promoted the prefix-match rules.

Add kind of a hack to get "Project X" sorting above all the "Project X (Milestone 1)" results.

Test Plan

Created "Ape Discovery", "Baboon Discovery", "Chimpanzee Discovery", etc.

Main project now sorts above milestones:

Screen Shot 2016-06-09 at 1.12.25 PM.png (247×467 px, 26 KB)

Prefix matches now sort above other matches:

Screen Shot 2016-06-09 at 1.12.29 PM.png (306×522 px, 27 KB)

Function results (rarely used) are now less prominent:

Screen Shot 2016-06-09 at 1.12.37 PM.png (242×412 px, 29 KB)

Better function results here:

Screen Shot 2016-06-09 at 1.12.42 PM.png (248×425 px, 34 KB)

More function results:

Screen Shot 2016-06-09 at 1.12.50 PM.png (225×377 px, 31 KB)

Diff Detail

Repository
rP Phabricator
Branch
typeahead1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12591
Build 15981: Run Core Tests
Build 15980: arc lint + arc unit