Fixes T11115, but unclear how to test this. I think I've asked this in the past.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T11115: Ponder Inbound E-Mail Enhancement
- Commits
- rPe808963eae75: Add Ponder Question mail create receiver
- Visit Applications -> Ponder
- Configure external email
- Test External Email
- See new Question
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- ponder-create-mail (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 12570 Build 15951: Run Core Tests Build 15950: arc lint + arc unit
Event Timeline
Comment Actions
I think you can test this with bin/mail receive-test. Something like this:
phabricator/ $ echo "test" | ./bin/mail receive-test --as chad --to ponder@whatever.comGive that a shot? We might need to add a --subject flag too, but that should theoretically work. If you don't get anywhere with it, let me know and I'll see if I can fix it so it works.
Comment Actions
Code itself looks good to me.
| src/applications/ponder/mail/PonderQuestionCreateMailReceiver.php | ||
|---|---|---|
| 20 | Incredibly minor, but this will prevent creating questions with great titles like "0" and "0.0". Doing if (!strlen($title)) instead will work for all titles. | |