Differential D16083

Fix parsing of anchors in Phriction document link syntax
ClosedPublic
Actions

Authored by epriestley on Jun 8 2016, 8:13 PM.

Details

Reviewers

chad

Maniphest Tasks

T4280: Embed anchor in remark up text and later link to it.

Commits

rP72d554aa9b67: Fix parsing of anchors in Phriction document link syntax

Summary

Ref T4280. At some point (probably D15732) we started getting anchor parsing wrong. Just pop the anchor off before doing all the logic, then put it back on at the end.

Test Plan

Tested various forms like:

[[ x ]]
[[ x | z ]]
[[ x#y | z ]]
[[ ./x#y | z ]]

Diff Detail

Repository

rP Phabricator

Branch

anchor1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12568
Build 15948: Run Core Tests
Build 15947: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38696.Jun 8 2016, 8:13 PM

epriestley retitled this revision from to Fix parsing of anchors in Phriction document link syntax.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4280: Embed anchor in remark up text and later link to it. .

chad accepted this revision.Jun 8 2016, 8:13 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 8 2016, 8:13 PM

Closed by commit rP72d554aa9b67: Fix parsing of anchors in Phriction document link syntax (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2016, 8:14 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10969: Incorrect Phriction link in email.Jun 9 2016, 2:56 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

markup/

PhrictionRemarkupRule.php

24 lines

infrastructure/

markup/

PhabricatorMarkupEngine.php

2 lines

Diff 38696

View Options

src/applications/phriction/markup/PhrictionRemarkupRule.php