Page MenuHomePhabricator

Make auth provider autologin modular and implement it for all OAuth2 adapters
ClosedPublic

Authored by epriestley on Jun 6 2016, 8:13 PM.
Tags
None
Referenced Files
F14384817: D16060.id38649.diff
Sat, Dec 21, 10:48 AM
F14383698: D16060.diff
Sat, Dec 21, 7:49 AM
Unknown Object (File)
Tue, Dec 10, 6:28 AM
Unknown Object (File)
Sun, Dec 8, 10:47 PM
Unknown Object (File)
Tue, Dec 3, 12:55 AM
Unknown Object (File)
Nov 3 2024, 4:40 PM
Unknown Object (File)
Oct 18 2024, 3:56 PM
Unknown Object (File)
Oct 18 2024, 3:56 PM
Subscribers
None

Details

Summary

Ref T10785. Around the time we launched Phacility SAAS we implemented this weird autologin hack. It works fine, so clean it up, get rid of the instanceof stuff, and support it for any OAuth2 provider.

(We could conceivably support OAuth1 as well, but no one has expressed an interest in it and I don't think I have any OAuth1 providers configured correctly locally so it would take a little bit to set up and test.)

Test Plan
  • Configured OAuth2 adapters (Facebook) for auto-login.
  • Saw no config option on other adapters (LDAP).
  • Nuked all options but one, did autologin with Facebook and Phabricator.
  • Logged out, got logout screen.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make auth provider autologin modular and implement it for all OAuth2 adapters.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 6 2016, 9:04 PM
This revision was automatically updated to reflect the committed changes.